From: Felipe Balbi <balbi@kernel.org>
To: Heinrich Schuchardt <xypron.glpk@gmx.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andrzej Pietrasiewicz <andrzej.p@samsung.com>,
John Youn <John.Youn@synopsys.com>,
Nicholas Bellinger <nab@linux-iscsi.org>,
Robert Baldyga <r.baldyga@samsung.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Alan Stern <stern@rowland.harvard.edu>
Subject: Re: [PATCH 1/1] usb: net2272: avoid shifting 0
Date: Mon, 09 May 2016 11:09:45 +0300 [thread overview]
Message-ID: <874ma7ps8m.fsf@intel.com> (raw)
In-Reply-To: <1462744969-4676-1-git-send-email-xypron.glpk@gmx.de>
Heinrich Schuchardt <xypron.glpk@gmx.de> writes:
> Remove redundant code.
> Or'ing with a shifted value of zero is a NOP.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
it sure is and the compiler is getting rid of those. They are there as
means of documentation only ;-)
I really have no strong feelings about this patch, so I'll let the other
folks who have been hacking on this to decide.
--
balbi
prev parent reply other threads:[~2016-05-09 8:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-08 22:02 [PATCH 1/1] usb: net2272: avoid shifting 0 Heinrich Schuchardt
2016-05-09 8:09 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874ma7ps8m.fsf@intel.com \
--to=balbi@kernel.org \
--cc=John.Youn@synopsys.com \
--cc=andrzej.p@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=r.baldyga@samsung.com \
--cc=stern@rowland.harvard.edu \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.