From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751285AbcEIIMJ (ORCPT <rfc822;w@1wt.eu>);
	Mon, 9 May 2016 04:12:09 -0400
Received: from mga14.intel.com ([192.55.52.115]:48032 "EHLO mga14.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750913AbcEIIMG (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 9 May 2016 04:12:06 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,600,1455004800"; 
   d="scan'208";a="961744371"
From: Felipe Balbi <balbi@kernel.org>
To: Heinrich Schuchardt <xypron.glpk@gmx.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Andrzej Pietrasiewicz <andrzej.p@samsung.com>,
        John Youn <John.Youn@synopsys.com>,
        Nicholas Bellinger <nab@linux-iscsi.org>,
        Robert Baldyga <r.baldyga@samsung.com>, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org, Heinrich Schuchardt <xypron.glpk@gmx.de>,
        Alan Stern <stern@rowland.harvard.edu>
Subject: Re: [PATCH 1/1] usb: net2272: avoid shifting 0
In-Reply-To: <1462744969-4676-1-git-send-email-xypron.glpk@gmx.de>
References: <1462744969-4676-1-git-send-email-xypron.glpk@gmx.de>
User-Agent: Notmuch/0.21+96~g9bbc54b (http://notmuchmail.org) Emacs/25.0.90.3 (x86_64-pc-linux-gnu)
Date: Mon, 09 May 2016 11:09:45 +0300
Message-ID: <874ma7ps8m.fsf@intel.com>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Heinrich Schuchardt <xypron.glpk@gmx.de> writes:
> Remove redundant code.
> Or'ing with a shifted value of zero is a NOP.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

it sure is and the compiler is getting rid of those. They are there as
means of documentation only ;-)

I really have no strong feelings about this patch, so I'll let the other
folks who have been hacking on this to decide.

-- 
balbi