From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754722AbbLKPOp (ORCPT ); Fri, 11 Dec 2015 10:14:45 -0500 Received: from mga14.intel.com ([192.55.52.115]:53603 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754048AbbLKPOn (ORCPT ); Fri, 11 Dec 2015 10:14:43 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,414,1444719600"; d="scan'208";a="871683121" From: Alexander Shishkin To: Peter Zijlstra Cc: Ingo Molnar , linux-kernel@vger.kernel.org, vince@deater.net, eranian@google.com, Arnaldo Carvalho de Melo , Mathieu Poirier Subject: Re: [PATCH v0 3/5] perf: Introduce instruction trace filtering In-Reply-To: <20151211145643.GS6356@twins.programming.kicks-ass.net> References: <1449840998-29902-1-git-send-email-alexander.shishkin@linux.intel.com> <1449840998-29902-4-git-send-email-alexander.shishkin@linux.intel.com> <20151211145643.GS6356@twins.programming.kicks-ass.net> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Fri, 11 Dec 2015 17:14:40 +0200 Message-ID: <874mfpc90f.fsf@ashishki-desk.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Peter Zijlstra writes: > On Fri, Dec 11, 2015 at 03:36:36PM +0200, Alexander Shishkin wrote: >> @@ -5921,6 +6010,8 @@ static void perf_event_comm_event(struct perf_comm_event *comm_event) >> >> comm_event->event_id.header.size = sizeof(comm_event->event_id) + size; >> >> + if (comm_event->event_id.header.misc == PERF_RECORD_MISC_COMM_EXEC) >> + perf_event_aux(perf_itrace_exec, comm_event, NULL, true); > > Maybe put this in perf_event_exec() ? Good point, I'm not actually even using the 'comm_event' in perf_itrace_exec() for anything. Thanks, -- Alex