From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915: Pin the ifbdev for the info->system_base GGTT mmapping Date: Fri, 09 Oct 2015 15:00:02 +0300 Message-ID: <874mi06ym5.fsf@intel.com> References: <20151008090737.GJ27939@nuc-i3427.alporthouse.com> <1444337421-20784-1-git-send-email-wayne.boyer@intel.com> <20151009091109.GJ27939@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 647336E315 for ; Fri, 9 Oct 2015 04:56:40 -0700 (PDT) In-Reply-To: <20151009091109.GJ27939@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , Wayne Boyer , Jesse Barnes Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, "Goel, Akash" , stable@vger.kernel.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCAwOSBPY3QgMjAxNSwgQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28u dWs+IHdyb3RlOgo+IE9uIFRodSwgT2N0IDA4LCAyMDE1IGF0IDAxOjUwOjIxUE0gLTA3MDAsIFdh eW5lIEJveWVyIHdyb3RlOgo+PiBGcm9tOiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNv bi5jby51az4KPj4gCj4+IEEgbG9uZyB0aW1lIGFnbyAoYmVmb3JlIDMuMTQpIHdlIHJlbGllZCBv biBhIHBlcm1hbmVudCBwaW5uaW5nIG9mIHRoZQo+PiBpZmJkZXYgdG8gbG9jayB0aGUgZmIgaW4g cGxhY2UgaW5zaWRlIHRoZSBHR1RULiBIb3dldmVyLCB0aGUKPj4gaW50cm9kdWN0aW9uIG9mIHN0 ZWFsaW5nIHRoZSBCSU9TIGZyYW1lYnVmZmVyIGFuZCByZXVzaW5nIGl0cyBhZGRyZXNzIGluCj4+ IHRoZSBHR1RUIGZvciB0aGUgZmJkZXYgaGFzIG11ZGRpZWQgd2F0ZXJzIGFuZCB3ZSB1c2UgYW4g aW5oZXJpdGVkIGZiLgo+PiBIb3dldmVyLCB0aGUgaW5oZXJpdGVkIGZiIGlzIG9ubHkgcGlubmVk IHdoaWxzdCBpdCBpcyBhY3RpdmUgYW5kIHdlIG5vCj4+IGxvbmdlciBoYXZlIGFuIGV4cGxpY2l0 IHBpbiBmb3IgdGhlIGluZm8tPnN5c3RlbV9iYXNlIG1tYXBwaW5nIHVzZWQgYnkKPj4gdGhlIGZi ZGV2LiBUaGUgcmVzdWx0IGlzIHRoYXQgYWZ0ZXIgc29tZSBhcGVydHVyZSBwcmVzc3VyZSB0aGUg ZmJkZXYgbWF5Cj4+IGJlIGV2aWN0ZWQsIGJ1dCB3ZSBjb250aW51ZSB0byB3cml0ZSB0aGUgZmJj b24gaW50byB0aGUgc2FtZSBHR1RUCj4+IGFkZHJlc3MgLSBvdmVyd3JpdGluZyBhbnl0aGluZyBl bHNlIHRoYXQgbWF5IGJlIHB1dCBpbnRvIHRoYXQgb2Zmc2V0Lgo+PiBUaGUgZWZmZWN0IGlzIG1v c3QgcHJvbm91bmNlZCBhY3Jvc3Mgc3VzcGVuZC9yZXN1bWUgYXMKPj4gaW50ZWxfZmJkZXZfc2V0 X3N1c3BlbmQoKSBkb2VzIGEgZnVsbCBjbGVhciBvdmVyIHRoZSB3aG9sZSBzY2Fub3V0Lgo+PiAK Pj4gdjI6IHJlYmFzZWQgb24gbGF0ZXN0IG5pZ2h0bHkgKFdheW5lKQo+PiB2MzogY2hhbmdlZCBp OTE1X2dlbV9vYmplY3RfZ2d0dF9waW4oKSB0byBpOTE1X2dlbV9vYmpfZ2d0dF9waW4oKSBiYXNl ZAo+PiBvbiBDaHJpcycgcmV2aWV3LiAoV2F5bmUpCj4KPiBOb3RlIHRoYXQgdGhpcyBwYXRjaCBh bHNvIGRlcGVuZHMgb24gdGhlCj4KPiAJZHJtL2k5MTU6IFNldCB0aGUgbWFwLWFuZC1mZW5jZWFi bGUgZmxhZyBmb3IgcHJlYWxsb2NhdGVkIG9iamVjdHMKPgo+IGZpeCBhcyB3ZWxsCj4gaHR0cDov L3BhdGNod29yay5mcmVlZGVza3RvcC5vcmcvcGF0Y2gvNTgwMjYvCgpKZXNzZSwgcGxlYXNlIHBy b3ZpZGUgeW91ciBUZXN0ZWQtYnkgb24gdGhhdCBwbHVzIHRoaXMgcGF0Y2gsIHNpbmNlIHlvdQpy ZXBvcnRlZCB0aGUgYnJlYWthZ2UgWzFdIHRoYXQgZ290IHRoZSB0d28gcGF0Y2hlcyByZXZlcnRl ZCBpbiB0aGUgZmlyc3QKcGxhY2UuCgpUaGFua3MsCkphbmkuCgoKWzFdIGh0dHA6Ly9taWQuZ21h bmUub3JnLzU1REYzODg2LjEwNjAwMDFAdmlydHVvdXNnZWVrLm9yZwoKPiAtQ2hyaXMKPgo+IC0t IAo+IENocmlzIFdpbHNvbiwgSW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50cmUKPiBf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdm eCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cDov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAoKLS0gCkph bmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBs aXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com ([134.134.136.24]:6355 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758304AbbJIL4k (ORCPT ); Fri, 9 Oct 2015 07:56:40 -0400 From: Jani Nikula To: Chris Wilson , Wayne Boyer , "Jesse Barnes" Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, stable@vger.kernel.org, "Goel\, Akash" Subject: Re: [Intel-gfx] [PATCH] drm/i915: Pin the ifbdev for the info->system_base GGTT mmapping In-Reply-To: <20151009091109.GJ27939@nuc-i3427.alporthouse.com> References: <20151008090737.GJ27939@nuc-i3427.alporthouse.com> <1444337421-20784-1-git-send-email-wayne.boyer@intel.com> <20151009091109.GJ27939@nuc-i3427.alporthouse.com> Date: Fri, 09 Oct 2015 15:00:02 +0300 Message-ID: <874mi06ym5.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: stable-owner@vger.kernel.org List-ID: On Fri, 09 Oct 2015, Chris Wilson wrote: > On Thu, Oct 08, 2015 at 01:50:21PM -0700, Wayne Boyer wrote: >> From: Chris Wilson >> >> A long time ago (before 3.14) we relied on a permanent pinning of the >> ifbdev to lock the fb in place inside the GGTT. However, the >> introduction of stealing the BIOS framebuffer and reusing its address in >> the GGTT for the fbdev has muddied waters and we use an inherited fb. >> However, the inherited fb is only pinned whilst it is active and we no >> longer have an explicit pin for the info->system_base mmapping used by >> the fbdev. The result is that after some aperture pressure the fbdev may >> be evicted, but we continue to write the fbcon into the same GGTT >> address - overwriting anything else that may be put into that offset. >> The effect is most pronounced across suspend/resume as >> intel_fbdev_set_suspend() does a full clear over the whole scanout. >> >> v2: rebased on latest nightly (Wayne) >> v3: changed i915_gem_object_ggtt_pin() to i915_gem_obj_ggtt_pin() based >> on Chris' review. (Wayne) > > Note that this patch also depends on the > > drm/i915: Set the map-and-fenceable flag for preallocated objects > > fix as well > http://patchwork.freedesktop.org/patch/58026/ Jesse, please provide your Tested-by on that plus this patch, since you reported the breakage [1] that got the two patches reverted in the first place. Thanks, Jani. [1] http://mid.gmane.org/55DF3886.1060001@virtuousgeek.org > -Chris > > -- > Chris Wilson, Intel Open Source Technology Centre > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Technology Center