From: Markus Armbruster <armbru@redhat.com>
To: marcandre.lureau@redhat.com
Cc: qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH v2 10/12] qga: add an optionnal qemu-ga.conf system configuration
Date: Wed, 26 Aug 2015 10:01:50 +0200 [thread overview]
Message-ID: <874mjmfpg1.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <1440540624-7998-11-git-send-email-marcandre.lureau@redhat.com> (marcandre lureau's message of "Wed, 26 Aug 2015 00:10:22 +0200")
marcandre.lureau@redhat.com writes:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Learn to configure the agent with a system configuration.
>
> This may simplify command-line handling, especially when the blacklist
> is long.
>
> Among the other benefits, this may standardize the configuration of a
> init service (instead of distro-specific init keys/files)
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
This uses GLib's Key-value file parser. Note that we have our own .ini
parser qemu_config_parse(). It predates our use of GLib. Having two
different parsers risks inconsistency. Since qga is already using
GLib's, using it some more there is better than adding a use of our own
parser, so no objection to your patch on that ground.
Replacing qemu_config_parse()'s parsing guts by GLib probably won't save
code, but it could be nice for consistency. Well outside this patch's
scope, of course.
next prev parent reply other threads:[~2015-08-26 8:07 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-25 22:10 [Qemu-devel] [PATCH v2 00/12] qemu-ga: add a configuration file marcandre.lureau
2015-08-25 22:10 ` [Qemu-devel] [PATCH v2 01/12] qga: misc spelling marcandre.lureau
2015-08-25 22:26 ` Michael Roth
2015-08-25 22:30 ` Eric Blake
2015-08-25 22:36 ` Marc-André Lureau
2015-08-25 22:10 ` [Qemu-devel] [PATCH v2 02/12] qga: use exit() when parsing options marcandre.lureau
2015-08-25 22:27 ` Michael Roth
2015-08-25 22:10 ` [Qemu-devel] [PATCH v2 03/12] qga: move string split in separate function marcandre.lureau
2015-08-25 22:10 ` [Qemu-devel] [PATCH v2 04/12] qga: rename 'path' to 'channel_path' marcandre.lureau
2015-08-25 22:29 ` Michael Roth
2015-08-25 22:10 ` [Qemu-devel] [PATCH v2 05/12] qga: copy argument strings marcandre.lureau
2015-08-25 22:31 ` Michael Roth
2015-08-25 22:10 ` [Qemu-devel] [PATCH v2 06/12] qga: move option parsing to seperate function marcandre.lureau
2015-08-25 22:40 ` Michael Roth
2015-08-25 22:10 ` [Qemu-devel] [PATCH v2 07/12] qga: fill default options in main() marcandre.lureau
2015-08-25 22:46 ` Michael Roth
2015-08-25 22:59 ` Marc-André Lureau
2015-08-25 22:10 ` [Qemu-devel] [PATCH v2 08/12] qga: move agent run in a seperate function marcandre.lureau
2015-08-25 22:55 ` Michael Roth
2015-08-25 22:10 ` [Qemu-devel] [PATCH v2 09/12] qga: free a bit more marcandre.lureau
2015-08-25 22:10 ` [Qemu-devel] [PATCH v2 10/12] qga: add an optionnal qemu-ga.conf system configuration marcandre.lureau
2015-08-25 23:09 ` Michael Roth
2015-08-25 23:18 ` Marc-André Lureau
2015-08-25 23:29 ` Michael Roth
2015-08-26 8:01 ` Markus Armbruster [this message]
2015-08-25 22:10 ` [Qemu-devel] [PATCH v2 11/12] qga: add --dump-conf option marcandre.lureau
2015-08-25 23:13 ` Michael Roth
2015-08-25 23:31 ` Marc-André Lureau
2015-08-25 22:10 ` [Qemu-devel] [PATCH v2 12/12] qga: start a man page marcandre.lureau
2015-08-25 23:16 ` Michael Roth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874mjmfpg1.fsf@blackfin.pond.sub.org \
--to=armbru@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.