From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54100)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1ZUVkL-00050n-JH
	for qemu-devel@nongnu.org; Wed, 26 Aug 2015 04:07:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1ZUVkI-0008E0-SL
	for qemu-devel@nongnu.org; Wed, 26 Aug 2015 04:07:49 -0400
Received: from mx1.redhat.com ([209.132.183.28]:53871)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1ZUVkI-0008Dm-Nt
	for qemu-devel@nongnu.org; Wed, 26 Aug 2015 04:07:46 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1440540624-7998-1-git-send-email-marcandre.lureau@redhat.com>
	<1440540624-7998-11-git-send-email-marcandre.lureau@redhat.com>
Date: Wed, 26 Aug 2015 10:01:50 +0200
In-Reply-To: <1440540624-7998-11-git-send-email-marcandre.lureau@redhat.com>
	(marcandre lureau's message of "Wed, 26 Aug 2015 00:10:22 +0200")
Message-ID: <874mjmfpg1.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2 10/12] qga: add an optionnal
	qemu-ga.conf system configuration
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: marcandre.lureau@redhat.com
Cc: qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com

marcandre.lureau@redhat.com writes:

> From: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>
>
> Learn to configure the agent with a system configuration.
>
> This may simplify command-line handling, especially when the blacklist
> is long.
>
> Among the other benefits, this may standardize the configuration of a
> init service (instead of distro-specific init keys/files)
>
> Signed-off-by: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>

This uses GLib's Key-value file parser.  Note that we have our own .ini
parser qemu_config_parse().  It predates our use of GLib.  Having two
different parsers risks inconsistency.  Since qga is already using
GLib's, using it some more there is better than adding a use of our own
parser, so no objection to your patch on that ground.

Replacing qemu_config_parse()'s parsing guts by GLib probably won't save
code, but it could be nice for consistency.  Well outside this patch's
scope, of course.