From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50217)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1ZL4oX-0004j9-Sg
	for qemu-devel@nongnu.org; Fri, 31 Jul 2015 03:33:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1ZL4oU-0001zG-K5
	for qemu-devel@nongnu.org; Fri, 31 Jul 2015 03:33:09 -0400
Received: from mail-wi0-f175.google.com ([209.85.212.175]:35336)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1ZL4oU-0001ym-DH
	for qemu-devel@nongnu.org; Fri, 31 Jul 2015 03:33:06 -0400
Received: by wibxm9 with SMTP id xm9so21381369wib.0
	for <qemu-devel@nongnu.org>; Fri, 31 Jul 2015 00:33:05 -0700 (PDT)
References: <1437755447-10537-1-git-send-email-aurelien@aurel32.net>
	<1437755447-10537-7-git-send-email-aurelien@aurel32.net>
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
In-reply-to: <1437755447-10537-7-git-send-email-aurelien@aurel32.net>
Date: Fri, 31 Jul 2015 08:32:52 +0100
Message-ID: <874mkkhjdn.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH for-2.5 06/10] tcg: don't abuse TCG type in
	tcg_gen_trunc_shr_i64_i32
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-devel@nongnu.org, Richard Henderson <rth@twiddle.net>


Aurelien Jarno <aurelien@aurel32.net> writes:

> The tcg_gen_trunc_shr_i64_i32 function takes a 64-bit argument and
> returns a 32-bit value. Directly call tcg_gen_op3 with the correct
> types instead of calling tcg_gen_op3i_i32 and abusing the TCG types.
>
> Reviewed-by: Richard Henderson <rth@twiddle.net>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

> ---
>  tcg/tcg-op.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tcg/tcg-op.c b/tcg/tcg-op.c
> index 61b64db..0e79fd1 100644
> --- a/tcg/tcg-op.c
> +++ b/tcg/tcg-op.c
> @@ -1752,8 +1752,8 @@ void tcg_gen_trunc_shr_i64_i32(TCGv_i32 ret, TCGv_i64 arg, unsigned count)
>              tcg_temp_free_i64(t);
>          }
>      } else if (TCG_TARGET_HAS_trunc_shr_i64_i32) {
> -        tcg_gen_op3i_i32(INDEX_op_trunc_shr_i64_i32, ret,
> -                         MAKE_TCGV_I32(GET_TCGV_I64(arg)), count);
> +        tcg_gen_op3(&tcg_ctx, INDEX_op_trunc_shr_i64_i32,
> +                    GET_TCGV_I32(ret), GET_TCGV_I64(arg), count);
>      } else if (count == 0) {
>          tcg_gen_mov_i32(ret, MAKE_TCGV_I32(GET_TCGV_I64(arg)));
>      } else {

-- 
Alex Bennée