From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Andrew Jones <drjones@redhat.com>,
Julien Grall <julien.grall@linaro.org>,
Keir Fraser <keir@xen.org>,
Ian Campbell <ian.campbell@citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Tim Deegan <tim@xen.org>, Olaf Hering <olaf@aepfle.de>,
David Vrabel <david.vrabel@citrix.com>,
Jan Beulich <jbeulich@suse.com>,
xen-devel@lists.xenproject.org,
Daniel De Graaf <dgdegra@tycho.nsa.gov>
Subject: Re: [PATCH v8 11/11] (lib)xl: soft reset support
Date: Wed, 15 Jul 2015 10:50:09 +0200 [thread overview]
Message-ID: <874ml5yfcu.fsf@vitty.brq.redhat.com> (raw)
In-Reply-To: <21925.13990.879217.737910@mariner.uk.xensource.com> (Ian Jackson's message of "Tue, 14 Jul 2015 17:19:50 +0100")
Ian Jackson <Ian.Jackson@eu.citrix.com> writes:
> Vitaly Kuznetsov writes ("[PATCH v8 11/11] (lib)xl: soft reset support"):
>> Use existing create/restore path to perform 'soft reset' for HVM domains.
>> Tear everything down, e.g. destroy domain's device model, remove the domain
>> from xenstore, save toolstack record and start over.
>
> This patch has a number of long lines (eg in the documentation and
> comments) which make it hard to review. Can you please keep it to 70
> columns, or 75 if you absolutely must ?
No problem, will do in v9. BTW, libxl/CODING_STYLE states that 'Lines
are limited to 75-80 characters'. I'd suggest we update that in case
70-75 is preferred.
>
> I'm not sure that this descriptiion:
>
>> +=item B<soft-reset>
>> +
>> +cleanup the domain without destroying it, restart the device
>> +model. This action is supported for HVM guests only.
>
> is really accurate from a user point of view.
Yea, I'm trying hard to avoid mentioning Linux and kexec while
describing soft reset. Will try to come up with something..
>
> Ian.
--
Vitaly
prev parent reply other threads:[~2015-07-15 8:50 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-23 16:11 [PATCH v8 00/11] toolstack-assisted approach to PVHVM guest kexec Vitaly Kuznetsov
2015-06-23 16:11 ` [PATCH v8 01/11] xen: introduce SHUTDOWN_soft_reset shutdown reason Vitaly Kuznetsov
2015-07-07 20:44 ` Konrad Rzeszutek Wilk
2015-07-14 16:10 ` Ian Jackson
2015-07-15 8:42 ` Vitaly Kuznetsov
2015-06-23 16:11 ` [PATCH v8 02/11] libxl: support " Vitaly Kuznetsov
2015-07-07 20:47 ` Konrad Rzeszutek Wilk
2015-07-14 16:15 ` Ian Jackson
2015-07-15 8:43 ` Vitaly Kuznetsov
2015-06-23 16:11 ` [PATCH v8 03/11] xl: introduce enum domain_restart_type Vitaly Kuznetsov
2015-07-07 20:48 ` Konrad Rzeszutek Wilk
2015-06-23 16:11 ` [PATCH v8 04/11] xen: evtchn: make evtchn_reset() ready for soft reset Vitaly Kuznetsov
2015-07-10 16:20 ` Konrad Rzeszutek Wilk
2015-06-23 16:11 ` [PATCH v8 05/11] xen: grant_table: implement grant_table_warn_active_grants() Vitaly Kuznetsov
2015-07-10 16:24 ` Konrad Rzeszutek Wilk
2015-07-13 8:45 ` Jan Beulich
2015-07-13 9:08 ` Ian Campbell
2015-07-13 9:30 ` Jan Beulich
2015-07-13 9:35 ` Vitaly Kuznetsov
2015-07-13 13:44 ` Vitaly Kuznetsov
2015-07-13 14:24 ` Konrad Rzeszutek Wilk
2015-06-23 16:11 ` [PATCH v8 06/11] xen: Introduce XEN_DOMCTL_soft_reset Vitaly Kuznetsov
2015-07-10 16:30 ` Konrad Rzeszutek Wilk
2015-06-23 16:11 ` [PATCH v8 07/11] flask: DOMCTL_soft_reset support Vitaly Kuznetsov
2015-07-13 19:43 ` Daniel De Graaf
2015-06-23 16:11 ` [PATCH v8 08/11] xen: arch-specific hooks for domain_soft_reset() Vitaly Kuznetsov
2015-07-10 16:54 ` Konrad Rzeszutek Wilk
2015-07-14 15:52 ` Vitaly Kuznetsov
2015-07-14 15:57 ` Konrad Rzeszutek Wilk
2015-07-14 16:07 ` Vitaly Kuznetsov
2015-07-15 20:19 ` Julien Grall
2015-07-16 11:36 ` Vitaly Kuznetsov
2015-07-16 11:57 ` Julien Grall
2015-06-23 16:11 ` [PATCH v8 09/11] libxc: support XEN_DOMCTL_soft_reset operation Vitaly Kuznetsov
2015-06-25 13:52 ` Wei Liu
2015-07-10 16:55 ` Konrad Rzeszutek Wilk
2015-07-14 16:17 ` Ian Jackson
2015-06-23 16:11 ` [PATCH v8 10/11] libxc: add XC_DEVICE_MODEL_SAVE_FILE Vitaly Kuznetsov
2015-06-23 16:11 ` [PATCH v8 11/11] (lib)xl: soft reset support Vitaly Kuznetsov
2015-07-10 16:59 ` Konrad Rzeszutek Wilk
2015-07-14 16:19 ` Ian Jackson
2015-07-15 8:50 ` Vitaly Kuznetsov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874ml5yfcu.fsf@vitty.brq.redhat.com \
--to=vkuznets@redhat.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=david.vrabel@citrix.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=drjones@redhat.com \
--cc=ian.campbell@citrix.com \
--cc=jbeulich@suse.com \
--cc=julien.grall@linaro.org \
--cc=keir@xen.org \
--cc=olaf@aepfle.de \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.