From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54273) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5wAj-0001va-OJ for qemu-devel@nongnu.org; Fri, 19 Jun 2015 09:17:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z5wAg-0006L9-FX for qemu-devel@nongnu.org; Fri, 19 Jun 2015 09:17:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59410) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5wAg-0006L5-Ab for qemu-devel@nongnu.org; Fri, 19 Jun 2015 09:17:26 -0400 From: Markus Armbruster References: <1434194302-26589-1-git-send-email-armbru@redhat.com> <1434194302-26589-2-git-send-email-armbru@redhat.com> <55840CC0.3070207@suse.de> Date: Fri, 19 Jun 2015 15:17:23 +0200 In-Reply-To: <55840CC0.3070207@suse.de> ("Andreas =?utf-8?Q?F=C3=A4rber=22?= =?utf-8?Q?'s?= message of "Fri, 19 Jun 2015 14:36:16 +0200") Message-ID: <874mm3on18.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 1/7] qdev: Deprecated qdev_init() is finally unused, drop List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?utf-8?Q?F=C3=A4rber?= Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, kraxel@redhat.com Andreas F=C3=A4rber writes: > Hi Markus, > > Could you please add a verbose rationale here like "qdev_init() does not > propagate the Error* and should be replaced by ..."? What about: qdev_init() is a wrapper around setting property "realized" to true plus error handling, which passes errors to qerror_report_err(). qerror_report_err() is a transitional interface to help with converting existing monitor commands to QMP. It should not be used elsewhere. All code has been modernized to avoid qdev_init() and its inappropriate error handling. We can finally drop it. > Am 13.06.2015 um 13:18 schrieb Markus Armbruster: >> Signed-off-by: Markus Armbruster >> Reviewed-by: Eric Blake >> --- >> hw/core/qdev.c | 47 ++++++++++++++++---------------------------= ---- >> include/hw/qdev-core.h | 3 +-- >> 2 files changed, 17 insertions(+), 33 deletions(-) > > Otherwise, > > Reviewed-by: Andreas F=C3=A4rber Thanks!