From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41397) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yn4cU-00083v-K4 for qemu-devel@nongnu.org; Tue, 28 Apr 2015 08:28:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yn4cQ-0000fj-K5 for qemu-devel@nongnu.org; Tue, 28 Apr 2015 08:28:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55166) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yn4cQ-0000ff-Cd for qemu-devel@nongnu.org; Tue, 28 Apr 2015 08:28:06 -0400 From: Markus Armbruster References: <1428206887-7921-1-git-send-email-eblake@redhat.com> <1428206887-7921-32-git-send-email-eblake@redhat.com> Date: Tue, 28 Apr 2015 14:28:02 +0200 In-Reply-To: <1428206887-7921-32-git-send-email-eblake@redhat.com> (Eric Blake's message of "Sat, 4 Apr 2015 22:08:02 -0600") Message-ID: <874mo0qvxp.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v6 31/36] qapi: Merge UserDefTwo and UserDefNested in tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kwolf@redhat.com, berto@igalia.co, qemu-devel@nongnu.org Eric Blake writes: > In the testsuite, UserDefTwo and UserDefNested were identical > structs other than the member names. Reduce code duplication by > having just one type, and choose names that also favor reuse. > This will also make it easier for a later patch to get rid of > inline nested types in QAPI. When touching code related to > allocations, convert g_malloc0(sizeof(Type)) to the more typesafe > g_new0(Type, 1). > > Ensure that 'make check-qapi-schema check-unit' still passes. > > Signed-off-by: Eric Blake Reviewed-by: Markus Armbruster