From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59393)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1XyzLB-0003Y6-1y
	for qemu-devel@nongnu.org; Thu, 11 Dec 2014 03:43:22 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1XyzL5-0001FP-JM
	for qemu-devel@nongnu.org; Thu, 11 Dec 2014 03:43:16 -0500
Received: from mx1.redhat.com ([209.132.183.28]:42816)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1XyzL5-0001EN-C8
	for qemu-devel@nongnu.org; Thu, 11 Dec 2014 03:43:11 -0500
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sBB8hArg004585
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Thu, 11 Dec 2014 03:43:10 -0500
From: Markus Armbruster <armbru@redhat.com>
References: <1418110684-19528-1-git-send-email-famz@redhat.com>
	<87oarbsm77.fsf@blackfin.pond.sub.org>
	<20141211002107.GB3110@ad.nay.redhat.com>
Date: Thu, 11 Dec 2014 09:43:07 +0100
In-Reply-To: <20141211002107.GB3110@ad.nay.redhat.com> (Fam Zheng's message of
	"Thu, 11 Dec 2014 08:21:07 +0800")
Message-ID: <874mt2mvac.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH for-2.3 0/2] block: Fix for trailing
	whitespace in qemu-img create and its tests
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, Max Reitz <mreitz@redhat.com>

Fam Zheng <famz@redhat.com> writes:

> On Wed, 12/10 13:50, Markus Armbruster wrote:
>> Fam Zheng <famz@redhat.com> writes:
>> 
>> > This will make it easier to keep checkpatch.pl happy.
>> >
>> > Fam Zheng (2):
>> >   qemu-iotests: Remove traling whitespaces in *.out
>> >   block: Don't add trailing space in "Formating..." message
>> 
>> Sounds like PATCH 1 breaks the test, and PATCH 2 unbreaks it.  If that's
>> the case, they need to be squashed.
>
> No. Our qemu-iotests driver ignores ending space:
>
>     if diff -w "$reference" $tmp.out >/dev/null 2>&1
>     then
>         echo ""
>         if $err
>         then
>             :
>         else
>             echo "$seq `expr $stop - $start`" >>$tmp.time
>         fi
>     else
>         echo " - output mismatch (see $seq.out.bad)"
>         mv $tmp.out $seq.out.bad
>         $diff -w "$reference" $seq.out.bad
>         err=true
>     fi

Right, thanks for the reminder :)

> Are you happy with the "sep" or do you want a full-fledged version?

Your choice.  The function is kind of odd, but it's not an important
one.

Series
Reviewed-by: Markus Armbruster <armbru@redhat.com>