From: Alex Bennée <alex.bennee@linaro.org>
To: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com,
rob.herring@linaro.org, aggelerf@ethz.ch, qemu-devel@nongnu.org,
agraf@suse.de, blauwirbel@gmail.com, john.williams@xilinx.com,
greg.bellows@linaro.org, pbonzini@redhat.com,
christoffer.dall@linaro.org, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH v1 06/16] target-arm: Add FAR_EL2 and 3
Date: Wed, 04 Jun 2014 08:55:30 +0100 [thread overview]
Message-ID: <874n01rtvx.fsf@linaro.org> (raw)
In-Reply-To: <20140604023346.GD3378@toto>
Edgar E. Iglesias writes:
> On Tue, Jun 03, 2014 at 11:22:51AM +0100, Alex Bennée wrote:
>>
>> Edgar E. Iglesias writes:
>>
>>
>> Ahh my confusion from earlier is now clear. Perhaps the two commits
>> should be merged?
>
> Hi,
>
> The point is to have a non-functional diff and then incrementally add
> the function to easy bisectability if something breaks. I don't
> have a very strong opinion though, so if people insist I can squash.
Having each commit point be buildable and testable is certainly a
worthwhile goal from a bisect point of view. But for a simple no-op diff
(i.e. functionaly identical, just moving a few bits around) which will
then get updated with functional changes there is an argument to squash
the two together.
I like this patch series because the individual patches are narrow in
scope and not too big hence easier to review. I don't think squashing
some of non-function + functional diffs together detracts from that
nobel goal. As you say it's a judgement call.
--
Alex Bennée
next prev parent reply other threads:[~2014-06-04 7:55 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1401434911-26992-1-git-send-email-edgar.iglesias@gmail.com>
[not found] ` <1401434911-26992-15-git-send-email-edgar.iglesias@gmail.com>
2014-06-02 1:30 ` [Qemu-devel] [PATCH v1 14/16] target-arm: A64: Emulate the SMC insn Edgar E. Iglesias
[not found] ` <CAOgzsHWqsegcukD8Q45daqbWPSNWoAbcYZcUm1Qe7Wgf=f4FxA@mail.gmail.com>
[not found] ` <20140531034925.GP18802@zapo.iiNet>
2014-06-02 16:12 ` Greg Bellows
2014-06-04 2:31 ` Edgar E. Iglesias
[not found] ` <1401434911-26992-2-git-send-email-edgar.iglesias@gmail.com>
2014-06-02 9:40 ` [Qemu-devel] [PATCH v1 01/16] target-arm: A64: Break out aarch64_save/restore_sp Alex Bennée
[not found] ` <1401434911-26992-3-git-send-email-edgar.iglesias@gmail.com>
2014-06-02 9:52 ` [Qemu-devel] [PATCH v1 02/16] target-arm: A64: Respect SPSEL in ERET SP restore Alex Bennée
[not found] ` <1401434911-26992-4-git-send-email-edgar.iglesias@gmail.com>
2014-06-02 9:55 ` [Qemu-devel] [PATCH v1 03/16] target-arm: A64: Respect SPSEL when taking exceptions Alex Bennée
[not found] ` <1401434911-26992-5-git-send-email-edgar.iglesias@gmail.com>
2014-06-03 10:21 ` [Qemu-devel] [PATCH v1 04/16] target-arm: Make far_el1 an array Alex Bennée
2014-06-03 12:42 ` Greg Bellows
2014-06-03 13:35 ` Alex Bennée
2014-06-03 13:50 ` Greg Bellows
[not found] ` <1401434911-26992-7-git-send-email-edgar.iglesias@gmail.com>
2014-06-03 10:22 ` [Qemu-devel] [PATCH v1 06/16] target-arm: Add FAR_EL2 and 3 Alex Bennée
2014-06-04 2:33 ` Edgar E. Iglesias
2014-06-04 7:55 ` Alex Bennée [this message]
2014-06-04 15:08 ` Edgar E. Iglesias
[not found] ` <1401434911-26992-8-git-send-email-edgar.iglesias@gmail.com>
2014-06-03 10:27 ` [Qemu-devel] [PATCH v1 07/16] target-arm: Add HCR_EL2 Alex Bennée
2014-06-04 6:52 ` Edgar E. Iglesias
[not found] ` <1401434911-26992-9-git-send-email-edgar.iglesias@gmail.com>
2014-06-03 10:30 ` [Qemu-devel] [PATCH v1 08/16] target-arm: Add SCR_EL3 Alex Bennée
[not found] ` <1401434911-26992-11-git-send-email-edgar.iglesias@gmail.com>
2014-06-03 10:32 ` [Qemu-devel] [PATCH v1 10/16] target-arm: Break out exception masking to a separate func Alex Bennée
2014-06-04 6:55 ` Edgar E. Iglesias
[not found] ` <1401434911-26992-13-git-send-email-edgar.iglesias@gmail.com>
2014-06-03 10:37 ` [Qemu-devel] [PATCH v1 12/16] target-arm: A64: Correct updates to FAR and ESR on exceptions Alex Bennée
[not found] ` <1401434911-26992-14-git-send-email-edgar.iglesias@gmail.com>
2014-06-03 10:41 ` [Qemu-devel] [PATCH v1 13/16] target-arm: A64: Emulate the HVC insn Alex Bennée
2014-06-04 7:01 ` Edgar E. Iglesias
2014-06-04 7:26 ` Alex Bennée
2014-06-04 15:03 ` Edgar E. Iglesias
[not found] ` <1401434911-26992-16-git-send-email-edgar.iglesias@gmail.com>
2014-06-03 10:47 ` [Qemu-devel] [PATCH v1 15/16] target-arm: Add IRQ and FIQ routing to EL2 and 3 Alex Bennée
[not found] ` <1401434911-26992-12-git-send-email-edgar.iglesias@gmail.com>
2014-06-08 15:51 ` [Qemu-devel] [PATCH v1 11/16] target-arm: Don't take interrupts targeting lower ELs Aggeler Fabian
2014-06-08 23:43 ` Edgar E. Iglesias
2014-06-10 17:10 ` Aggeler Fabian
2014-08-01 14:35 ` [Qemu-devel] [PATCH v1 00/16] target-arm: Parts of the AArch64 EL2/3 exception model Peter Maydell
2014-08-01 14:38 ` Peter Maydell
2014-08-05 8:53 ` Edgar E. Iglesias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874n01rtvx.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=aggelerf@ethz.ch \
--cc=agraf@suse.de \
--cc=blauwirbel@gmail.com \
--cc=christoffer.dall@linaro.org \
--cc=edgar.iglesias@gmail.com \
--cc=greg.bellows@linaro.org \
--cc=john.williams@xilinx.com \
--cc=pbonzini@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rob.herring@linaro.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.