From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51078)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1Wk8sz-0003Lf-UD
	for qemu-devel@nongnu.org; Tue, 13 May 2014 05:20:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1Wk8sy-000391-Pm
	for qemu-devel@nongnu.org; Tue, 13 May 2014 05:20:33 -0400
Received: from static.88-198-71-155.clients.your-server.de
	([88.198.71.155]:32828 helo=socrates.bennee.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1Wk8sy-00038t-7C
	for qemu-devel@nongnu.org; Tue, 13 May 2014 05:20:32 -0400
References: <1399938424-6703-1-git-send-email-rth@twiddle.net>
	<1399938424-6703-4-git-send-email-rth@twiddle.net>
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
In-reply-to: <1399938424-6703-4-git-send-email-rth@twiddle.net>
Date: Tue, 13 May 2014 10:20:40 +0100
Message-ID: <874n0u826v.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 03/10] tcg: Push tcg-runtime routines into
	exec/helper-*
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org, aurelien@aurel32.net


Richard Henderson <rth@twiddle.net> writes:

> Rather than special casing them, use the standard mechanisms
> for tcg helper generation.
>
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
>  include/exec/helper-gen.h   |  1 +
>  include/exec/helper-head.h  | 12 ++++++++----
>  include/exec/helper-proto.h |  1 +
>  include/exec/helper-tcg.h   |  1 +
>  tcg-runtime.c               | 40 +++++++++++++++++++++++++---------------
>  tcg/tcg-op.h                | 35 ++++++++++++++++++-----------------
>  tcg/tcg-runtime.h           | 30 +++++++++++++-----------------
>  tcg/tcg.c                   | 16 ----------------
>  tcg/tcg.h                   |  2 --
>  9 files changed, 67 insertions(+), 71 deletions(-)
>
> diff --git a/include/exec/helper-gen.h b/include/exec/helper-gen.h
> index f6d9ec3..abde615 100644
> --- a/include/exec/helper-gen.h
> +++ b/include/exec/helper-gen.h
> @@ -80,6 +80,7 @@ static inline void glue(gen_helper_, name)(dh_retvar_decl(ret) \
>  }
>  
>  #include "helper.h"
> +#include "tcg-runtime.h"
>  
>  #undef DEF_HELPER_FLAGS_0
>  #undef DEF_HELPER_FLAGS_1
> diff --git a/include/exec/helper-head.h b/include/exec/helper-head.h
> index 2cbae22..0b5bd83 100644
> --- a/include/exec/helper-head.h
> +++ b/include/exec/helper-head.h
> @@ -18,6 +18,8 @@
>  #ifndef DEF_HELPER_H
>  #define DEF_HELPER_H 1
>  
> +#include "qemu/osdep.h"
> +
>  #define HELPER(name) glue(helper_, name)
>  
>  #define GET_TCGV_i32 GET_TCGV_I32
> @@ -32,10 +34,12 @@
>  #define dh_alias_s64 i64
>  #define dh_alias_f32 i32
>  #define dh_alias_f64 i64
> -#if TARGET_LONG_BITS == 32
> -#define dh_alias_tl i32
> -#else
> -#define dh_alias_tl i64
> +#ifdef TARGET_LONG_BITS
> +# if TARGET_LONG_BITS == 32
> +#  define dh_alias_tl i32
> +# else
> +#  define dh_alias_tl i64
> +# endif

This bit seems unrelated to the rest of the patch. In fact I can't see
any uses of the dh_alias_* in the code base although there is some
dh_alias() glue magic that could be throwing me off.

>  #endif
<snip>

Otherwise:

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée