From: Jani Nikula <jani.nikula@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>,
Chris Wilson <chris@chris-wilson.co.uk>,
intel-gfx@lists.freedesktop.org, Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH] drm/i915: Fix unsafe loop iteration over vma whilst unbinding them
Date: Fri, 21 Mar 2014 13:09:48 +0200 [thread overview]
Message-ID: <874n2rq03n.fsf@intel.com> (raw)
In-Reply-To: <20140321095723.GY30571@phenom.ffwll.local>
On Fri, 21 Mar 2014, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Fri, Mar 21, 2014 at 07:51:58AM +0000, Chris Wilson wrote:
>> On Fri, Mar 21, 2014 at 07:40:56AM +0000, Chris Wilson wrote:
>> > On non-LLC platforms, when changing the cache level of an object, we may
>> > need to unbind it show that prefetching across page boundaries does not
>> s/show/so/
>> > cross into a different memory domain. This requires us to unbind
>> > conflicting vma, but we did so was iterating over the objects vma in an
>> s/was//
>> > unsafe manner (as the list was being modified as we iterated).
>>
>> Coffee will kick in in about 5 minutes.
>
> Fixed and applied, thanks for the patch.
Given the regression was introduced in v3.12 I thought this would've
been fixes & cc: stable.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
next prev parent reply other threads:[~2014-03-21 11:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-21 7:40 [PATCH] drm/i915: Fix unsafe loop iteration over vma whilst unbinding them Chris Wilson
2014-03-21 7:51 ` Chris Wilson
2014-03-21 9:57 ` Daniel Vetter
2014-03-21 11:09 ` Jani Nikula [this message]
2014-03-21 15:12 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874n2rq03n.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=ben@bwidawsk.net \
--cc=chris@chris-wilson.co.uk \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.