From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@linux.intel.com>
Subject: Re: [PATCH] drm/i915: Fix unsafe loop iteration over
	vma whilst unbinding them
Date: Fri, 21 Mar 2014 13:09:48 +0200
Message-ID: <874n2rq03n.fsf@intel.com>
References: <1395387656-12212-1-git-send-email-chris@chris-wilson.co.uk>
 <20140321075158.GC5419@nuc-i3427.alporthouse.com>
 <20140321095723.GY30571@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by gabe.freedesktop.org (Postfix) with ESMTP id 9F2416E2AB
 for <intel-gfx@lists.freedesktop.org>; Fri, 21 Mar 2014 04:09:33 -0700 (PDT)
In-Reply-To: <20140321095723.GY30571@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Daniel Vetter <daniel@ffwll.ch>, Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org, Ben Widawsky <ben@bwidawsk.net>
List-Id: intel-gfx@lists.freedesktop.org

On Fri, 21 Mar 2014, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Fri, Mar 21, 2014 at 07:51:58AM +0000, Chris Wilson wrote:
>> On Fri, Mar 21, 2014 at 07:40:56AM +0000, Chris Wilson wrote:
>> > On non-LLC platforms, when changing the cache level of an object, we may
>> > need to unbind it show that prefetching across page boundaries does not
>> s/show/so/
>> > cross into a different memory domain. This requires us to unbind
>> > conflicting vma, but we did so was iterating over the objects vma in an
>> s/was//
>> > unsafe manner (as the list was being modified as we iterated).
>> 
>> Coffee will kick in in about 5 minutes.
>
> Fixed and applied, thanks for the patch.

Given the regression was introduced in v3.12 I thought this would've
been fixes & cc: stable.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center