From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rusty Russell Date: Mon, 17 Mar 2014 03:48:48 +0000 Subject: Re: [PATCH v2 2/2] kallsyms: handle special absolute symbols Message-Id: <874n2xts1b.fsf@rustcorp.com.au> List-Id: References: <1394240425-11647-1-git-send-email-keescook@chromium.org> <1394240425-11647-3-git-send-email-keescook@chromium.org> <87y50fuei5.fsf@rustcorp.com.au> <87lhwevk98.fsf@rustcorp.com.au> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Kees Cook Cc: Linus Torvalds , Andrew Morton , Andrew Honig , Michal Marek , "x86@kernel.org" , Tejun Heo , Tony Luck , Fenghua Yu , linux-ia64@vger.kernel.org, LKML Kees Cook writes: > On Wed, Mar 12, 2014 at 8:40 PM, Rusty Russell wrote: >> Kees Cook writes: >>> Why not just do this with 0-base-address detection like my v2? That >>> would mean we don't need to remember to add this flag in the future to >>> imagined new architectures that might want this 0-based per_cpu >>> feature. >> >> Because future architectures will get this right and emit absolute >> symbols. I hope! >> >> I'm swamped at the moment, but am hoping to investigate that for >> x86-64. This is a stop-gap. > > Okay, I'm convinced. :) > > Acked-by: Kees Cook > > Thanks! Applied, thanks. Cheers, Rusty. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932251AbaCQEkb (ORCPT ); Mon, 17 Mar 2014 00:40:31 -0400 Received: from ozlabs.org ([203.10.76.45]:43146 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750888AbaCQEjc (ORCPT ); Mon, 17 Mar 2014 00:39:32 -0400 From: Rusty Russell To: Kees Cook Cc: Linus Torvalds , Andrew Morton , Andrew Honig , Michal Marek , "x86\@kernel.org" , Tejun Heo , Tony Luck , Fenghua Yu , linux-ia64@vger.kernel.org, LKML Subject: Re: [PATCH v2 2/2] kallsyms: handle special absolute symbols In-Reply-To: References: <1394240425-11647-1-git-send-email-keescook@chromium.org> <1394240425-11647-3-git-send-email-keescook@chromium.org> <87y50fuei5.fsf@rustcorp.com.au> <87lhwevk98.fsf@rustcorp.com.au> User-Agent: Notmuch/0.15.2 (http://notmuchmail.org) Emacs/23.4.1 (x86_64-pc-linux-gnu) Date: Mon, 17 Mar 2014 14:06:48 +1030 Message-ID: <874n2xts1b.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Kees Cook writes: > On Wed, Mar 12, 2014 at 8:40 PM, Rusty Russell wrote: >> Kees Cook writes: >>> Why not just do this with 0-base-address detection like my v2? That >>> would mean we don't need to remember to add this flag in the future to >>> imagined new architectures that might want this 0-based per_cpu >>> feature. >> >> Because future architectures will get this right and emit absolute >> symbols. I hope! >> >> I'm swamped at the moment, but am hoping to investigate that for >> x86-64. This is a stop-gap. > > Okay, I'm convinced. :) > > Acked-by: Kees Cook > > Thanks! Applied, thanks. Cheers, Rusty.