From: David Kastrup <dak@gnu.org>
To: Nemina Amarasinghe <neminaa@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] simplified the chain if() statements of install_branch_config() function in branch.c
Date: Mon, 10 Mar 2014 10:27:22 +0100 [thread overview]
Message-ID: <874n369zet.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <loom.20140310T101112-236@post.gmane.org> (Nemina Amarasinghe's message of "Mon, 10 Mar 2014 09:15:10 +0000 (UTC)")
Nemina Amarasinghe <neminaa@gmail.com> writes:
>> > ((!remote_is_branch && origin) || (!remote_is_branch || !origin))
>>
>> Is it?
>>
>> The above is the same as (!remote_is_branch || !origin). What you wrote
>> before is the same as (!remote_is_branch).
>>
>> Maybe you should try copy&paste from the expressions you are trying to
>> combine to make sure that what you start with makes sense.
>>
> OMG.. Really sorry for that... that was a silly mistake.
> This is the one..
>
> ((!remote_is_branch && origin) || (!remote_is_branch && !origin))
That is, indeed, perfectly equivalent to (!remote_is_branch). If you
write
(!remote_is_branch && (origin || !origin))
then you will have people (and possibly also the compiler) loudly
wondering about what you are trying to say here. The suspicion would be
that either this is a result of a typo or is supposed to be an
annoyingly obtuse replacement for a
/* TODO: treat origin and !origin differently */
kind of comment.
--
David Kastrup
next prev parent reply other threads:[~2014-03-10 9:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-10 7:39 [PATCH] simplified the chain if() statements of install_branch_config() function in branch.c Nemina Amarasinghe
2014-03-10 7:58 ` Nemina Amarasinghe
2014-03-10 8:23 ` Matthieu Moy
2014-03-10 8:36 ` David Kastrup
2014-03-10 8:51 ` Nemina Amarasinghe
2014-03-10 9:05 ` Matthieu Moy
2014-03-10 9:08 ` David Kastrup
2014-03-10 9:15 ` Nemina Amarasinghe
2014-03-10 9:27 ` David Kastrup [this message]
2014-03-10 20:46 ` Eric Sunshine
2014-03-11 6:30 ` Nemina Amarasinghe
2014-03-11 8:06 ` Eric Sunshine
2014-03-11 7:16 ` [PATCH][GSoC]simplified branch.c:install_branch_config() if() statement Nemina Amarasinghe
2014-03-11 8:11 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874n369zet.fsf@fencepost.gnu.org \
--to=dak@gnu.org \
--cc=git@vger.kernel.org \
--cc=neminaa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.