All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ath10k: fix tracing of ath10k_wmi_cmd
@ 2013-09-19  7:44 ` Michal Kazior
  0 siblings, 0 replies; 4+ messages in thread
From: Michal Kazior @ 2013-09-19  7:44 UTC (permalink / raw)
  To: ath10k; +Cc: linux-wireless, Michal Kazior

One of my recent patches broke tracing. kbuild
test robot reported this issue.

Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
---
 drivers/net/wireless/ath/ath10k/trace.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath10k/trace.h b/drivers/net/wireless/ath/ath10k/trace.h
index fd53130..90817dd 100644
--- a/drivers/net/wireless/ath/ath10k/trace.h
+++ b/drivers/net/wireless/ath/ath10k/trace.h
@@ -119,7 +119,7 @@ TRACE_EVENT(ath10k_wmi_cmd,
 		__field(unsigned int, id)
 		__field(size_t, buf_len)
 		__dynamic_array(u8, buf, buf_len)
-		__field(int ret)
+		__field(int, ret)
 	),
 
 	TP_fast_assign(
-- 
1.7.9.5


_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] ath10k: fix tracing of ath10k_wmi_cmd
@ 2013-09-19  7:44 ` Michal Kazior
  0 siblings, 0 replies; 4+ messages in thread
From: Michal Kazior @ 2013-09-19  7:44 UTC (permalink / raw)
  To: ath10k; +Cc: linux-wireless, Michal Kazior

One of my recent patches broke tracing. kbuild
test robot reported this issue.

Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
---
 drivers/net/wireless/ath/ath10k/trace.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath10k/trace.h b/drivers/net/wireless/ath/ath10k/trace.h
index fd53130..90817dd 100644
--- a/drivers/net/wireless/ath/ath10k/trace.h
+++ b/drivers/net/wireless/ath/ath10k/trace.h
@@ -119,7 +119,7 @@ TRACE_EVENT(ath10k_wmi_cmd,
 		__field(unsigned int, id)
 		__field(size_t, buf_len)
 		__dynamic_array(u8, buf, buf_len)
-		__field(int ret)
+		__field(int, ret)
 	),
 
 	TP_fast_assign(
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] ath10k: fix tracing of ath10k_wmi_cmd
  2013-09-19  7:44 ` Michal Kazior
@ 2013-09-20  5:01   ` Kalle Valo
  -1 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2013-09-20  5:01 UTC (permalink / raw)
  To: Michal Kazior; +Cc: linux-wireless, ath10k

Michal Kazior <michal.kazior@tieto.com> writes:

> One of my recent patches broke tracing. kbuild
> test robot reported this issue.
>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>

Bad luck as I had accidentally tracing disabled on my test build. Patch
applied, but changed the commit log to:

commit 9e84f653ac16b718dd2305abe64a29bb3428621e
Author: Michal Kazior <michal.kazior@tieto.com>
Date:   Thu Sep 19 09:44:09 2013 +0200

    ath10k: fix tracing build for ath10k_wmi_cmd
    
    Commit be8b394390 ("ath10k: make WMI commands block by design") broke
    the build if CONFIG_ATH10K_TRACING was enabled.
    
    Reported-by: kbuild test robot <fengguang.wu@intel.com>
    Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
    Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ath10k: fix tracing of ath10k_wmi_cmd
@ 2013-09-20  5:01   ` Kalle Valo
  0 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2013-09-20  5:01 UTC (permalink / raw)
  To: Michal Kazior; +Cc: ath10k, linux-wireless

Michal Kazior <michal.kazior@tieto.com> writes:

> One of my recent patches broke tracing. kbuild
> test robot reported this issue.
>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>

Bad luck as I had accidentally tracing disabled on my test build. Patch
applied, but changed the commit log to:

commit 9e84f653ac16b718dd2305abe64a29bb3428621e
Author: Michal Kazior <michal.kazior@tieto.com>
Date:   Thu Sep 19 09:44:09 2013 +0200

    ath10k: fix tracing build for ath10k_wmi_cmd
    
    Commit be8b394390 ("ath10k: make WMI commands block by design") broke
    the build if CONFIG_ATH10K_TRACING was enabled.
    
    Reported-by: kbuild test robot <fengguang.wu@intel.com>
    Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
    Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>

-- 
Kalle Valo

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2013-09-20  5:01 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-19  7:44 [PATCH] ath10k: fix tracing of ath10k_wmi_cmd Michal Kazior
2013-09-19  7:44 ` Michal Kazior
2013-09-20  5:01 ` Kalle Valo
2013-09-20  5:01   ` Kalle Valo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.