From: "Bjørn Mork" <bjorn-yOkvZcmFvRU@public.gmane.org>
To: Steve Glendinning
<steve.glendinning-nksJyM/082jR7s880joybQ@public.gmane.org>
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 4/5] smsc95xx: refactor entering suspend modes
Date: Mon, 26 Nov 2012 14:48:40 +0100 [thread overview]
Message-ID: <874nkcscef.fsf@nemi.mork.no> (raw)
In-Reply-To: <1353607526-19307-5-git-send-email-steve.glendinning-nksJyM/082jR7s880joybQ@public.gmane.org> (Steve Glendinning's message of "Thu, 22 Nov 2012 18:05:25 +0000")
[adding linux-usb to CC as this is very USB specific]
Steve Glendinning <steve.glendinning-nksJyM/082jR7s880joybQ@public.gmane.org> writes:
> + smsc95xx_set_feature(dev, USB_DEVICE_REMOTE_WAKEUP);
That does look a bit strange to me. This is a USB interface driver.
The USB device is handled by the generic "usb" USB device driver, which
will DTRT for you. I don't think you need to set any USB device
features here.
Sorry for not commenting on this earlier.... It took me a while to
understand why that part surprised me.
Bjørn
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-11-26 13:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-22 18:05 [PATCH 0/5] smsc95xx updates Steve Glendinning
2012-11-22 18:05 ` [PATCH 1/5] smsc95xx: fix error checking of usbnet_resume Steve Glendinning
2012-11-22 20:32 ` David Miller
2012-11-23 12:55 ` Steve Glendinning
2012-11-22 18:05 ` [PATCH 2/5] smsc95xx: detect chip revision specific features Steve Glendinning
2012-11-22 18:05 ` [PATCH 3/5] smsc95xx: support PHY wakeup source Steve Glendinning
2012-11-22 18:05 ` [PATCH 4/5] smsc95xx: refactor entering suspend modes Steve Glendinning
[not found] ` <1353607526-19307-5-git-send-email-steve.glendinning-nksJyM/082jR7s880joybQ@public.gmane.org>
2012-11-26 13:48 ` Bjørn Mork [this message]
2012-11-22 18:05 ` [PATCH 5/5][RFC] smsc95xx: enable dynamic autosuspend (RFC) Steve Glendinning
2012-12-10 11:51 ` [PATCH][RFC] " Steve Glendinning
[not found] ` <1355140301-10518-1-git-send-email-steve.glendinning-nksJyM/082jR7s880joybQ@public.gmane.org>
2012-12-10 12:09 ` Oliver Neukum
2012-12-10 14:18 ` Steve Glendinning
[not found] ` <CAKh2mn5LgZBJDJWNzN8A3NK72Vk_fiUjJfmdn5njSrm400q36w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-12-11 2:24 ` Ming Lei
2012-12-11 10:27 ` Oliver Neukum
[not found] ` <1881907.JmjSTg2PBW-ugxBuEnWX9yG/4A2pS7c2Q@public.gmane.org>
2012-12-11 12:53 ` Ming Lei
2012-12-11 13:12 ` Steve Glendinning
2012-12-11 15:19 ` Oliver Neukum
2012-12-11 15:58 ` Ming Lei
2012-12-10 13:59 ` Ming Lei
2012-11-23 19:15 ` [PATCH 0/5] smsc95xx updates David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874nkcscef.fsf@nemi.mork.no \
--to=bjorn-yokvzcmfvru@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=steve.glendinning-nksJyM/082jR7s880joybQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.