From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rusty Russell Subject: Re: [PATCHv8 0/3]virtio_console: Add rproc_serial driver Date: Tue, 06 Nov 2012 12:23:31 +1030 Message-ID: <874nl35wf8.fsf@rustcorp.com.au> References: <1351587113-2566-1-git-send-email-sjur@brendeland.net> <877gq1yora.fsf@rustcorp.com.au> <20121105103124.GA12402@amit.redhat.com> <20121105103144.GB12402@amit.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20121105103144.GB12402@amit.redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Amit Shah Cc: "Michael S. Tsirkin" , Sjur =?utf-8?Q?Br=C3=A6ndeland?= , Linus Walleij , linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Masami Hiramatsu , Sjur =?utf-8?Q?Br=C3=A6ndeland?= List-Id: virtualization@lists.linuxfoundation.org QW1pdCBTaGFoIDxhbWl0LnNoYWhAcmVkaGF0LmNvbT4gd3JpdGVzOgo+IE9uIChNb24pIDA1IE5v diAyMDEyIFsxMTozMToyNF0sIEFtaXQgU2hhaCB3cm90ZToKPj4gT24gKE1vbikgMDUgTm92IDIw MTIgWzA5OjExOjQ1XSwgUnVzdHkgUnVzc2VsbCB3cm90ZToKPj4gPiBTanVyIEJyw6ZuZGVsYW5k IDxzanVyQGJyZW5kZWxhbmQubmV0PiB3cml0ZXM6Cj4+ID4gCj4+ID4gPiBGcm9tOiBTanVyIEJy w6ZuZGVsYW5kIDxzanVyLmJyYW5kZWxhbmRAc3Rlcmljc3Nvbi5jb20+Cj4+ID4gPgo+PiA+ID4g VGhpcyBwYXRjaC1zZXQgaW50cm9kdWNlcyBhIG5ldyB2aXJ0aW8gdHlwZSAicnByb2Nfc2VyaWFs IiBmb3IgY29tbXVuaWNhdGluZwo+PiA+ID4gd2l0aCByZW1vdGUgcHJvY2Vzc29ycyBvdmVyIHNo YXJlZCBtZW1vcnkuIFRoZSBkcml2ZXIgZGVwZW5kcyBvbiB0aGUKPj4gPiA+IHRoZSByZW1vdGVw cm9jIGZyYW1ld29yay4gQXMgcHJlcGFyYXRpb24gZm9yIGludHJvZHVjaW5nICJycHJvY19zZXJp YWwiCj4+ID4gPiBJJ3ZlIGRvbmUgYSByZWZhY3RvcmluZyBvZiB0aGUgdHJhbnNtaXQgYnVmZmVy IGhhbmRsaW5nLgo+PiA+ID4KPj4gPiA+IENoYW5nZXMgc2luY2Ugdjc6Cj4+ID4gPiAtIFJlYmFz ZWQgdG8gdmlydGlvLW5leHQgYnJhbmNoLgo+PiA+ID4gLSBSZW1vdmVkIGV4dHJhIGFkZGVkIGxp bmVzLgo+PiA+ID4gLSBSZW1vdmVkIHN1cGVyZmx1b3VzIGNoZWNrcyBiZWZvcmUgY2FsbGluZyBy ZWNsYWltX2RtYV9idWZzKCkuCj4+ID4gPiAtIFJ1c3R5IHJhaXNlZCBzb21lIHF1ZXN0aW9uIHJl Z2FyZGluZyBnYXJiYWdlIGNvbGxlY3Rpb24gb2YgdGhlCj4+ID4gPiAgIG91dC12cSwgc28gSSBt b3ZlZCB0aGlzIGludG8gYSBzZXBhcmF0ZSBwYXRjaC4KPj4gPiAKPj4gPiBPSywgSSdtIG5vdCBz dXJlIHRoYXQgV0FSTl9PTiB3b24ndCBmaXJlLCBidXQgdGhhdCdzIG5vdCBhbGwgdGhhdAo+PiA+ IGhhcm1mdWwuCj4+IAo+PiBTanVyIHNhaWQgaGUnbGwgc2VuZCBvdXQgYSByZXNwaW4gZm9yIHRo aXM7IGNhbiB5b3Ugd2FpdCBmb3IgaGlzIHY4Pwo+Cj4gRXIsIHY5Lgo+Cj4gCQlBbWl0CgpZZXAs IHRoZXkncmUgaW4gbXkgcGVuZGluZy1yZWJhc2VzIHRyZWUgbm93LgoKVGhvdWdoIG5vIG5lZWQg dG8gcmVwb3N0IHRoZSB3aG9sZSBzZXJpZXM7IGp1c3QgdGhlIGNoYW5nZXMgcGxlYXNlLgoKQ2hl ZXJzLApSdXN0eS4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KVmlydHVhbGl6YXRpb24gbWFpbGluZyBsaXN0ClZpcnR1YWxpemF0aW9uQGxpc3RzLmxpbnV4 LWZvdW5kYXRpb24ub3JnCmh0dHBzOi8vbGlzdHMubGludXhmb3VuZGF0aW9uLm9yZy9tYWlsbWFu L2xpc3RpbmZvL3ZpcnR1YWxpemF0aW9u From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933625Ab2KFCKm (ORCPT ); Mon, 5 Nov 2012 21:10:42 -0500 Received: from ozlabs.org ([203.10.76.45]:50283 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933186Ab2KFCKk convert rfc822-to-8bit (ORCPT ); Mon, 5 Nov 2012 21:10:40 -0500 From: Rusty Russell To: Amit Shah Cc: Sjur =?utf-8?Q?Br=C3=A6ndeland?= , "Michael S. Tsirkin" , Linus Walleij , Masami Hiramatsu , Ohad Ben-Cohen , linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, sjurbren@gmail.com, Sjur =?utf-8?Q?Br=C3=A6ndeland?= Subject: Re: [PATCHv8 0/3]virtio_console: Add rproc_serial driver In-Reply-To: <20121105103144.GB12402@amit.redhat.com> References: <1351587113-2566-1-git-send-email-sjur@brendeland.net> <877gq1yora.fsf@rustcorp.com.au> <20121105103124.GA12402@amit.redhat.com> <20121105103144.GB12402@amit.redhat.com> User-Agent: Notmuch/0.14 (http://notmuchmail.org) Emacs/23.4.1 (i686-pc-linux-gnu) Date: Tue, 06 Nov 2012 12:23:31 +1030 Message-ID: <874nl35wf8.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Amit Shah writes: > On (Mon) 05 Nov 2012 [11:31:24], Amit Shah wrote: >> On (Mon) 05 Nov 2012 [09:11:45], Rusty Russell wrote: >> > Sjur Brændeland writes: >> > >> > > From: Sjur Brændeland >> > > >> > > This patch-set introduces a new virtio type "rproc_serial" for communicating >> > > with remote processors over shared memory. The driver depends on the >> > > the remoteproc framework. As preparation for introducing "rproc_serial" >> > > I've done a refactoring of the transmit buffer handling. >> > > >> > > Changes since v7: >> > > - Rebased to virtio-next branch. >> > > - Removed extra added lines. >> > > - Removed superfluous checks before calling reclaim_dma_bufs(). >> > > - Rusty raised some question regarding garbage collection of the >> > > out-vq, so I moved this into a separate patch. >> > >> > OK, I'm not sure that WARN_ON won't fire, but that's not all that >> > harmful. >> >> Sjur said he'll send out a respin for this; can you wait for his v8? > > Er, v9. > > Amit Yep, they're in my pending-rebases tree now. Though no need to repost the whole series; just the changes please. Cheers, Rusty.