All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Gerd Hoffmann <kraxel@redhat.com>,
	Peter Maydell <peter.maydell@linaro.org>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] qemu <-> libvirt interaction broken
Date: Tue, 23 Oct 2012 07:47:48 -0500	[thread overview]
Message-ID: <874nllfj7v.fsf@codemonkey.ws> (raw)
In-Reply-To: <5086582C.4020804@redhat.com>

Gerd Hoffmann <kraxel@redhat.com> writes:

> On 10/23/12 10:19, Peter Maydell wrote:
>> On 23 October 2012 08:03, Gerd Hoffmann <kraxel@redhat.com> wrote:
>>> On 10/22/12 15:51, Peter Maydell wrote:
>>>> On 22 October 2012 14:28, Gerd Hoffmann <kraxel@redhat.com> wrote:
>>>>> Commit 585f60368f23e6603cf86cfdaeceb89d1169f4b8 appearently breaks the
>>>>> libvirt feature detection, my guests fail to start with this message:
>>>>>
>>>>> error: Failed to start domain fedora-org-virtio
>>>>> error: internal error qemu does not support SGA
>>>>>
>>>>> Running libvirt-0.10.2-2.el6.x86_64
>>>>
>>>> Yeah, this is the commit that means you need an updated libvirt
>>>> from this point on (and in particular for qemu-1.3).
>>>
>>> Well, only problem is that 0.10.2 already is the latest libvirt release.
>>>  Was it really intentional to break things like this?
>> 
>> This change was postponed to after 1.2 was released to
>> give libvirt a chance to wean itself off parsing our --help
>> output.
>
> Yea, I know this has been the plan for a long time and I agree that it
> is a good move.
>
> Only problem is that the switch didn't happen yet.  The bits might be
> landed in libvirt/master, but there is no release with this yet and thus
> libvirt versions using QOM for feature detection didn't find the way yet
> into distributions.
>
> IMO it is a bit early to stop caring about -help output compatibility in
> qemu.

It was announced.  There's been plenty of time to adapt.

If you're using QEMU from git, it's reasonable to require libvirt from
git IMHO.

By the time 1.3 goes out, there should be a libvirt release with the
necessary support so if your using distro packages, you'll never notice.

Regards,

Anthony Liguori

>
> cheers,
>   Gerd

  reply	other threads:[~2012-10-23 12:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-22 13:28 [Qemu-devel] qemu <-> libvirt interaction broken Gerd Hoffmann
2012-10-22 13:51 ` Peter Maydell
2012-10-23  7:03   ` Gerd Hoffmann
2012-10-23  8:19     ` Peter Maydell
2012-10-23  8:41       ` Gerd Hoffmann
2012-10-23 12:47         ` Anthony Liguori [this message]
2012-10-23 13:07           ` Eric Blake
2012-10-23 14:28             ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874nllfj7v.fsf@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=aurelien@aurel32.net \
    --cc=kraxel@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.