From: Namhyung Kim <namhyung@kernel.org>
To: Pekka Enberg <penberg@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] perf ui/gtk: Ensure not to call gtk_main_quit() twice
Date: Mon, 20 Aug 2012 10:55:24 +0900 [thread overview]
Message-ID: <874nnyjpir.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <878vdajpr6.fsf@sejong.aot.lge.com> (Namhyung Kim's message of "Mon, 20 Aug 2012 10:50:21 +0900")
On Mon, 20 Aug 2012 10:50:21 +0900, Namhyung Kim wrote:
> On Sat, 18 Aug 2012 10:52:03 +0300, Pekka Enberg wrote:
>> Wouldn't it be nicer to rearrange the callers so that perf_gtk__exit()
>> is not called twice?
>
> You mean this?
>
>
> diff --git a/tools/perf/ui/setup.c b/tools/perf/ui/setup.c
> index c7820e569660..d25e145e9a89 100644
> --- a/tools/perf/ui/setup.c
> +++ b/tools/perf/ui/setup.c
> @@ -2,6 +2,7 @@
>
> #include "../cache.h"
> #include "../debug.h"
> +#include "gtk/gtk.h"
Oops, it should be
#ifndef NO_GTK2_SUPPORT
# include "gtk/gtk.h"
#endif
Thanks,
Namhyung
>
>
> pthread_mutex_t ui__lock = PTHREAD_MUTEX_INITIALIZER;
> @@ -37,7 +38,8 @@ void exit_browser(bool wait_for_ok)
> {
> switch (use_browser) {
> case 2:
> - perf_gtk__exit(wait_for_ok);
> + if (perf_gtk__is_active_context(pgctx))
> + perf_gtk__exit(wait_for_ok);
> break;
>
> case 1:
next prev parent reply other threads:[~2012-08-20 2:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-17 16:56 [PATCH] perf ui/gtk: Ensure not to call gtk_main_quit() twice Namhyung Kim
2012-08-18 7:52 ` Pekka Enberg
2012-08-20 1:50 ` Namhyung Kim
2012-08-20 1:55 ` Namhyung Kim [this message]
2012-08-20 1:59 ` Namhyung Kim
2012-08-20 5:04 ` Pekka Enberg
2012-08-21 16:29 ` [tip:perf/core] perf ui gtk: " tip-bot for Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874nnyjpir.fsf@sejong.aot.lge.com \
--to=namhyung@kernel.org \
--cc=acme@ghostprotocols.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=penberg@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.