From: Kevin Hilman <khilman-l0cyMroinI0@public.gmane.org>
To: Shubhrajyoti D <shubhrajyoti-l0cyMroinI0@public.gmane.org>
Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH RFC] MFD: OMAP: USB: Make the runtime functions depend on CONFIG_PM_RUNTIME
Date: Tue, 03 Jan 2012 16:14:07 -0800 [thread overview]
Message-ID: <874nwc8gts.fsf@ti.com> (raw)
In-Reply-To: <1325572979-6090-1-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org> (Shubhrajyoti D.'s message of "Tue, 3 Jan 2012 12:12:59 +0530")
Shubhrajyoti D <shubhrajyoti-l0cyMroinI0@public.gmane.org> writes:
> Currently the runtime functions are compiled regardless
> of CONFIG_PM_RUNTIME flag. This patch intends to fix the same by
> using SET_RUNTIME_PM_OPS.
>
> Cc : Keshava Munegowda <keshava_mgowda-l0cyMroinI0@public.gmane.org>
> Signed-off-by: Shubhrajyoti D <shubhrajyoti-l0cyMroinI0@public.gmane.org>
> ---
> applies on Tony's ehci branch.
> Compile tested only.
You also should compile test this with runtime PM disabled. I believe
the current patch will lead to 'function defined but not used' warnings.
Kevin
> drivers/mfd/omap-usb-host.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
> index 3f565ef..ef72ebe 100644
> --- a/drivers/mfd/omap-usb-host.c
> +++ b/drivers/mfd/omap-usb-host.c
> @@ -887,8 +887,8 @@ static int __devexit usbhs_omap_remove(struct platform_device *pdev)
> }
>
> static const struct dev_pm_ops usbhsomap_dev_pm_ops = {
> - .runtime_suspend = usbhs_runtime_suspend,
> - .runtime_resume = usbhs_runtime_resume,
> + SET_RUNTIME_PM_OPS(usbhs_runtime_suspend,
> + usbhs_runtime_resume, NULL)
> };
>
> static struct platform_driver usbhs_omap_driver = {
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC] MFD: OMAP: USB: Make the runtime functions depend on CONFIG_PM_RUNTIME
Date: Tue, 03 Jan 2012 16:14:07 -0800 [thread overview]
Message-ID: <874nwc8gts.fsf@ti.com> (raw)
In-Reply-To: <1325572979-6090-1-git-send-email-shubhrajyoti@ti.com> (Shubhrajyoti D.'s message of "Tue, 3 Jan 2012 12:12:59 +0530")
Shubhrajyoti D <shubhrajyoti@ti.com> writes:
> Currently the runtime functions are compiled regardless
> of CONFIG_PM_RUNTIME flag. This patch intends to fix the same by
> using SET_RUNTIME_PM_OPS.
>
> Cc : Keshava Munegowda <keshava_mgowda@ti.com>
> Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
> ---
> applies on Tony's ehci branch.
> Compile tested only.
You also should compile test this with runtime PM disabled. I believe
the current patch will lead to 'function defined but not used' warnings.
Kevin
> drivers/mfd/omap-usb-host.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
> index 3f565ef..ef72ebe 100644
> --- a/drivers/mfd/omap-usb-host.c
> +++ b/drivers/mfd/omap-usb-host.c
> @@ -887,8 +887,8 @@ static int __devexit usbhs_omap_remove(struct platform_device *pdev)
> }
>
> static const struct dev_pm_ops usbhsomap_dev_pm_ops = {
> - .runtime_suspend = usbhs_runtime_suspend,
> - .runtime_resume = usbhs_runtime_resume,
> + SET_RUNTIME_PM_OPS(usbhs_runtime_suspend,
> + usbhs_runtime_resume, NULL)
> };
>
> static struct platform_driver usbhs_omap_driver = {
next prev parent reply other threads:[~2012-01-04 0:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-03 6:42 [PATCH RFC] MFD: OMAP: USB: Make the runtime functions depend on CONFIG_PM_RUNTIME Shubhrajyoti D
2012-01-03 6:42 ` Shubhrajyoti D
[not found] ` <1325572979-6090-1-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2012-01-04 0:14 ` Kevin Hilman [this message]
2012-01-04 0:14 ` Kevin Hilman
2012-01-09 11:30 ` Shubhrajyoti Datta
2012-01-09 11:30 ` Shubhrajyoti Datta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874nwc8gts.fsf@ti.com \
--to=khilman-l0cymroini0@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=shubhrajyoti-l0cyMroinI0@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.