From: Peter Korsgaard <jacmet@sunsite.dk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] net/bootp.c: fix tftp load if autoload environment var isn't set
Date: Mon, 19 Sep 2011 17:29:24 +0200 [thread overview]
Message-ID: <874o085z57.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <CAPnjgZ0Lh59CpwVEzt2Z667N9KzMChh=3FguSnbnw31aa6pLYA@mail.gmail.com> (Simon Glass's message of "Mon, 19 Sep 2011 08:02:48 -0700")
>>>>> "Simon" == Simon Glass <sjg@chromium.org> writes:
Hi,
Simon> I think we just had this discussion at the end of August. It
Simon> would be good to get to the bottom of why this commit is
Simon> considered a change of behaviour - it is something subtle that I
Simon> cannot see.
Because with that commit it no longer calls TftpStart() if the autoload
variable isn't set (it moved into the if (getenv..) conditional).
Simon> But first: if autoload is not defined, it is supposed to default to
Simon> 'y'. If you want it to be 'n' then you need to set it. It that what
Simon> you expect?
Yes, no autoload should behave like autoload=y, E.G. call TftpStart().
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2011-09-19 15:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-19 7:54 [U-Boot] [PATCH] net/bootp.c: fix tftp load if autoload environment var isn't set Peter Korsgaard
2011-09-19 13:47 ` Fabio Estevam
2011-09-19 15:02 ` Simon Glass
2011-09-19 15:29 ` Peter Korsgaard [this message]
2011-09-19 15:48 ` Simon Glass
2011-09-19 21:25 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874o085z57.fsf@macbook.be.48ers.dk \
--to=jacmet@sunsite.dk \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.