From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Korsgaard Date: Mon, 19 Sep 2011 17:29:24 +0200 Subject: [U-Boot] [PATCH] net/bootp.c: fix tftp load if autoload environment var isn't set In-Reply-To: (Simon Glass's message of "Mon, 19 Sep 2011 08:02:48 -0700") References: <1316418886-13495-1-git-send-email-jacmet@sunsite.dk> Message-ID: <874o085z57.fsf@macbook.be.48ers.dk> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de >>>>> "Simon" == Simon Glass writes: Hi, Simon> I think we just had this discussion at the end of August. It Simon> would be good to get to the bottom of why this commit is Simon> considered a change of behaviour - it is something subtle that I Simon> cannot see. Because with that commit it no longer calls TftpStart() if the autoload variable isn't set (it moved into the if (getenv..) conditional). Simon> But first: if autoload is not defined, it is supposed to default to Simon> 'y'. If you want it to be 'n' then you need to set it. It that what Simon> you expect? Yes, no autoload should behave like autoload=y, E.G. call TftpStart(). -- Bye, Peter Korsgaard