diff for duplicates of <874o5bg2n8.fsf@ti.com> diff --git a/a/1.txt b/N1/1.txt index de31be1..cab94a0 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -4,7 +4,7 @@ > > On Sat, Apr 23, 2011 at 04:32, Kevin Hilman <khilman@ti.com> wrote: >> Remove cpu_is_* checks from gpio_show_revision() by passing in the ->> revision address offset from platform data. SoCs with no revision +>> revision address offset from platform data. ?SoCs with no revision >> register (15xx, 7xx, and all MPUIOs) use -1 to signify no register. >> >> While here, all GPIO banks are assumed to be the same revision, so fix @@ -13,23 +13,23 @@ >> >> Signed-off-by: Kevin Hilman <khilman@ti.com> >> --- ->> arch/arm/mach-omap1/gpio15xx.c | 2 ++ ->> arch/arm/mach-omap1/gpio16xx.c | 2 ++ ->> arch/arm/mach-omap1/gpio7xx.c | 2 ++ ->> arch/arm/mach-omap2/gpio.c | 2 ++ ->> arch/arm/plat-omap/gpio.c | 14 ++++++-------- ->> arch/arm/plat-omap/include/plat/gpio.h | 1 + ->> 6 files changed, 15 insertions(+), 8 deletions(-) +>> ?arch/arm/mach-omap1/gpio15xx.c ? ? ? ? | ? ?2 ++ +>> ?arch/arm/mach-omap1/gpio16xx.c ? ? ? ? | ? ?2 ++ +>> ?arch/arm/mach-omap1/gpio7xx.c ? ? ? ? ?| ? ?2 ++ +>> ?arch/arm/mach-omap2/gpio.c ? ? ? ? ? ? | ? ?2 ++ +>> ?arch/arm/plat-omap/gpio.c ? ? ? ? ? ? ?| ? 14 ++++++-------- +>> ?arch/arm/plat-omap/include/plat/gpio.h | ? ?1 + +>> ?6 files changed, 15 insertions(+), 8 deletions(-) >> >> diff --git a/arch/arm/mach-omap1/gpio15xx.c b/arch/arm/mach-omap1/gpio15xx.c >> index 9175624..6f77c36 100644 >> --- a/arch/arm/mach-omap1/gpio15xx.c >> +++ b/arch/arm/mach-omap1/gpio15xx.c >> @@ -35,6 +35,7 @@ static struct __initdata resource omap15xx_mpu_gpio_resources[] = { ->> }; +>> ?}; >> ->> static struct omap_gpio_reg_offs omap15xx_mpuio_regs = { ->> + .revision = -1, +>> ?static struct omap_gpio_reg_offs omap15xx_mpuio_regs = { +>> + ? ? ? .revision ? ? ? = -1, > > Assigning -1 to u16 type. Instead you may want to use 0xffff? > @@ -38,7 +38,3 @@ The compiler will do the right thing, so personally, I prefer using -1. It's safer if/when the type is changed, but the mask not updated. Kevin --- -To unsubscribe from this list: send the line "unsubscribe linux-omap" in -the body of a message to majordomo@vger.kernel.org -More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index f26c949..5252328 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,13 +1,10 @@ "ref\01303513327-14532-1-git-send-email-khilman@ti.com\0" "ref\01303513327-14532-16-git-send-email-khilman@ti.com\0" "ref\0BANLkTimwFezON_qX+wr3Gj+A3EOEbD81YQ@mail.gmail.com\0" - "From\0Kevin Hilman <khilman@ti.com>\0" - "Subject\0Re: [PATCH 15/15] OMAP: GPIO: cleanup show revision, remove cpu_is checks, display only once\0" + "From\0khilman@ti.com (Kevin Hilman)\0" + "Subject\0[PATCH 15/15] OMAP: GPIO: cleanup show revision, remove cpu_is checks, display only once\0" "Date\0Tue, 03 May 2011 09:38:51 -0700\0" - "To\0Varadarajan" - " Charulatha <charu@ti.com>\0" - "Cc\0linux-omap@vger.kernel.org" - " linux-arm-kernel@lists.infradead.org\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "\"Varadarajan, Charulatha\" <charu@ti.com> writes:\n" @@ -16,7 +13,7 @@ ">\n" "> On Sat, Apr 23, 2011 at 04:32, Kevin Hilman <khilman@ti.com> wrote:\n" ">> Remove cpu_is_* checks from gpio_show_revision() by passing in the\n" - ">> revision address offset from platform data. \302\240SoCs with no revision\n" + ">> revision address offset from platform data. ?SoCs with no revision\n" ">> register (15xx, 7xx, and all MPUIOs) use -1 to signify no register.\n" ">>\n" ">> While here, all GPIO banks are assumed to be the same revision, so fix\n" @@ -25,23 +22,23 @@ ">>\n" ">> Signed-off-by: Kevin Hilman <khilman@ti.com>\n" ">> ---\n" - ">> \302\240arch/arm/mach-omap1/gpio15xx.c \302\240 \302\240 \302\240 \302\240 | \302\240 \302\2402 ++\n" - ">> \302\240arch/arm/mach-omap1/gpio16xx.c \302\240 \302\240 \302\240 \302\240 | \302\240 \302\2402 ++\n" - ">> \302\240arch/arm/mach-omap1/gpio7xx.c \302\240 \302\240 \302\240 \302\240 \302\240| \302\240 \302\2402 ++\n" - ">> \302\240arch/arm/mach-omap2/gpio.c \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 | \302\240 \302\2402 ++\n" - ">> \302\240arch/arm/plat-omap/gpio.c \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240| \302\240 14 ++++++--------\n" - ">> \302\240arch/arm/plat-omap/include/plat/gpio.h | \302\240 \302\2401 +\n" - ">> \302\2406 files changed, 15 insertions(+), 8 deletions(-)\n" + ">> ?arch/arm/mach-omap1/gpio15xx.c ? ? ? ? | ? ?2 ++\n" + ">> ?arch/arm/mach-omap1/gpio16xx.c ? ? ? ? | ? ?2 ++\n" + ">> ?arch/arm/mach-omap1/gpio7xx.c ? ? ? ? ?| ? ?2 ++\n" + ">> ?arch/arm/mach-omap2/gpio.c ? ? ? ? ? ? | ? ?2 ++\n" + ">> ?arch/arm/plat-omap/gpio.c ? ? ? ? ? ? ?| ? 14 ++++++--------\n" + ">> ?arch/arm/plat-omap/include/plat/gpio.h | ? ?1 +\n" + ">> ?6 files changed, 15 insertions(+), 8 deletions(-)\n" ">>\n" ">> diff --git a/arch/arm/mach-omap1/gpio15xx.c b/arch/arm/mach-omap1/gpio15xx.c\n" ">> index 9175624..6f77c36 100644\n" ">> --- a/arch/arm/mach-omap1/gpio15xx.c\n" ">> +++ b/arch/arm/mach-omap1/gpio15xx.c\n" ">> @@ -35,6 +35,7 @@ static struct __initdata resource omap15xx_mpu_gpio_resources[] = {\n" - ">> \302\240};\n" + ">> ?};\n" ">>\n" - ">> \302\240static struct omap_gpio_reg_offs omap15xx_mpuio_regs = {\n" - ">> + \302\240 \302\240 \302\240 .revision \302\240 \302\240 \302\240 = -1,\n" + ">> ?static struct omap_gpio_reg_offs omap15xx_mpuio_regs = {\n" + ">> + ? ? ? .revision ? ? ? = -1,\n" ">\n" "> Assigning -1 to u16 type. Instead you may want to use 0xffff?\n" ">\n" @@ -49,10 +46,6 @@ "The compiler will do the right thing, so personally, I prefer using -1.\n" "It's safer if/when the type is changed, but the mask not updated.\n" "\n" - "Kevin\n" - "--\n" - "To unsubscribe from this list: send the line \"unsubscribe linux-omap\" in\n" - "the body of a message to majordomo@vger.kernel.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + Kevin -670b69f08ed4bd88e2f4184c32434ed194dd098455281f58a586e79a9c821f3a +9cbd3ebba4dceadbd16c8d8ee836a1c049fefbb4f9eb09a04fdfe6acd1fafe57
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.