All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@ti.com>
To: Vishwanath Sripathy <vishwanath.bs@ti.com>
Cc: Shweta Gulati <shweta.gulati@ti.com>, linux-omap@vger.kernel.org
Subject: Re: Smartreflex on 'pm-wip/voltdm' Branch
Date: Mon, 28 Mar 2011 09:27:05 -0700	[thread overview]
Message-ID: <874o6nky7a.fsf@ti.com> (raw)
In-Reply-To: <e3b58bb0f126f8849c7358c8f7e67222@mail.gmail.com> (Vishwanath Sripathy's message of "Mon, 28 Mar 2011 19:10:01 +0530")

Vishwa, Shweta,

Vishwanath Sripathy <vishwanath.bs@ti.com> writes:

[...]

>> I am testing Smartreflex on your Branch 'pm-wip/voltdm'. There seems
>> an issue with reading VP registers.
>> For OMAP3 and OMAP4 reading debugfs entries shows constant voltage.

Thanks for testing.

[...]

> I did a quick debug on this and found that the root cause of the issue is
> in usage of ffs (because of this, i2c slave address was configured wrongly
> in vc).
> Basically ffs returns the position of the first (least significant) bit
> set in the word and the least significant bit is position 1 where as our
> bit operation assumes that least significant position is 0.

Vishwa, Thanks for findingg this.  Indeed, I had assumed ffs() was zero based,
but it is 1 based.  

> I tested the attached patch on OMAP3 and it seems to work fine.

> Kevin,
> You may want to incorporate this change in your next version if this seems
> OK to you.

Yes, I will fix this in forthcoming versions.

Thanks,

Kevin

  reply	other threads:[~2011-03-28 16:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-28 10:53 Smartreflex on 'pm-wip/voltdm' Branch Gulati, Shweta
2011-03-28 13:40 ` Vishwanath Sripathy
2011-03-28 16:27   ` Kevin Hilman [this message]
2011-03-30  6:21     ` Gulati, Shweta
2011-03-30 14:52       ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874o6nky7a.fsf@ti.com \
    --to=khilman@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=shweta.gulati@ti.com \
    --cc=vishwanath.bs@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.