From: Andi Kleen <andi@firstfloor.org>
To: David VomLehn <dvomlehn@cisco.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH][RFC] Infrastructure for compact call location representation
Date: Wed, 09 Jun 2010 09:17:47 +0200 [thread overview]
Message-ID: <874ohc65es.fsf@basil.nowhere.org> (raw)
In-Reply-To: <20100608003052.GA29377@dvomlehn-lnx2.corp.sa.net> (David VomLehn's message of "Mon\, 7 Jun 2010 17\:30\:52 -0700")
David VomLehn <dvomlehn@cisco.com> writes:
First your mailer generates broken cc addresses like
"netdev@vger.kernel.org"@cisco.com
> This patch allows the location of a call to be recorded as a small integer,
> with each call location ("callsite") assigned a new value the first time
> the code in that location is executed. Locations can be recorded as a
> an address or as a __FILE__/__LINE__ pair. The later is easier to read, but
> requires significantly more space.
Seems overly complicated.
How about using a hash of __FILE__, __LINE__ instead?
With some care you can write it in a way that it gets completely
evaluated by gcc at compile time, so it's just a constant then.
That may use a few more bits then, but that's far better
than having so much runtime overhead for this.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2010-06-09 7:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-08 0:30 [PATCH][RFC] Infrastructure for compact call location representation David VomLehn
2010-06-08 15:44 ` Randy Dunlap
2010-06-08 18:59 ` David VomLehn
2010-06-08 15:44 ` Stephen Hemminger
2010-06-08 19:06 ` David VomLehn
2010-06-09 8:44 ` Nick Piggin
2010-06-09 18:22 ` David VomLehn
2010-06-10 8:47 ` Nick Piggin
2010-06-09 7:17 ` Andi Kleen [this message]
2010-06-09 18:13 ` David VomLehn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874ohc65es.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=dvomlehn@cisco.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.