All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vitaly Mayatskikh <v.mayatskih@gmail.com>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Vivek Goyal <vgoyal@redhat.com>,
	Randy Dunlap <rdunlap@xenotime.net>
Subject: Re: [PATCH 2/5] x86: Split __show_regs()
Date: Wed, 02 Jun 2010 12:00:47 +0200	[thread overview]
Message-ID: <874ohl21ps.wl%vmayatsk@redhat.com> (raw)
In-Reply-To: <AANLkTinrOEg4b0cc2gKppw6bi4xvz4fveWmqAj6SPlvZ@mail.gmail.com>

At Wed, 2 Jun 2010 12:50:03 +0300, Pekka Enberg wrote:
> 
> On Wed, Jun 2, 2010 at 10:39 AM, Vitaly Mayatskikh
> <v.mayatskih@gmail.com> wrote:
> > __show_regs dumps content of pt_regs and does other things beside
> > it. This patch moves pt_regs dumping part into separate function:
> > __show_main_regs.
> >
> > Signed-off-by: Vitaly Mayatskikh <v.mayatskih@gmail.com>
> 
> [snip]
> 
> > +void __show_regs(struct pt_regs *regs, int all)
> > +{
> > +       unsigned long cr0 = 0L, cr2 = 0L, cr3 = 0L, cr4 = 0L;
> > +       unsigned long d0, d1, d2, d3, d6, d7;
> > +
> > +
> 
> Nitpick: extra newline here.

Thanks for catching!

-- 
wbr, Vitaly

  reply	other threads:[~2010-06-02 10:00 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-02  7:39 [PATCH 0/5] kdump: extract log buffer and registers from vmcore on NMI button pressing Vitaly Mayatskikh
2010-06-02  7:39 ` [PATCH 1/5] x86: Introduce ELF_CORE_EXTRACT_REGS Vitaly Mayatskikh
2010-06-02  7:39 ` [PATCH 2/5] x86: Split __show_regs() Vitaly Mayatskikh
2010-06-02  9:50   ` Pekka Enberg
2010-06-02 10:00     ` Vitaly Mayatskikh [this message]
2010-06-02  7:39 ` [PATCH 3/5] vmcore: Introduce dump_old_log() Vitaly Mayatskikh
2010-06-02  7:39 ` [PATCH 4/5] x86: Add new callback for unhandled NMIs Vitaly Mayatskikh
2010-06-02  7:39 ` [PATCH 5/5] Document unknown_nmi_dump_log variable Vitaly Mayatskikh
2010-06-02 15:16 ` [PATCH 0/5] kdump: extract log buffer and registers from vmcore on NMI button pressing Vivek Goyal
2010-06-03  9:01   ` Vitaly Mayatskikh
2010-06-03  9:30     ` Andi Kleen
2010-06-03 12:33       ` Vitaly Mayatskikh
2010-06-03 15:13         ` Andi Kleen
2010-06-04  9:32           ` Vitaly Mayatskikh
2010-06-04 10:15             ` Andi Kleen
2010-06-04 13:58               ` Vitaly Mayatskikh
2010-06-04  9:49           ` Américo Wang
2010-06-04 10:16             ` Andi Kleen
2010-06-04 14:49             ` Vivek Goyal
2010-06-04 14:42     ` Vivek Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874ohl21ps.wl%vmayatsk@redhat.com \
    --to=v.mayatskih@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=penberg@cs.helsinki.fi \
    --cc=rdunlap@xenotime.net \
    --cc=tglx@linutronix.de \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.