From: "Aneesh Kumar K. V" <aneesh.kumar@linux.vnet.ibm.com>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: hch@infradead.org, viro@zeniv.linux.org.uk, adilger@sun.com,
corbet@lwn.net, serue@us.ibm.com, neilb@suse.de,
hooanon05@yahoo.co.jp, linux-fsdevel@vger.kernel.org,
sfrench@us.ibm.com, philippe.deniel@CEA.FR,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -V11 1/9] exportfs: Return the minimum required handle size
Date: Sat, 22 May 2010 14:02:23 +0530 [thread overview]
Message-ID: <874oi02v6w.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <20100521221516.GD13227@fieldses.org>
On Fri, 21 May 2010 18:15:16 -0400, "J. Bruce Fields" <bfields@fieldses.org> wrote:
> On Thu, May 20, 2010 at 01:05:30PM +0530, Aneesh Kumar K.V wrote:
> > The exportfs encode handle function should return the minimum required
> > handle size. This helps user to find out the handle size by passing 0
> > handle size in the first step and then redoing to the call again with
> > the returned handle size value.
>
> The encode_fh() interface is a little confusing. (Not your fault,
> really, mainly it's the return value (and the special use of 255) that I
> always find odd.)
>
> But maybe it would help to have a little more documention in the
> export_encode_fh() kerneldoc comment and/or in
> Documentation/filesystems/nfs/Exporting?
>
Will update in the next iteration.
-aneesh
next prev parent reply other threads:[~2010-05-22 8:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-20 7:35 [PATCH -V11 0/9] Generic name to handle and open by handle syscalls Aneesh Kumar K.V
2010-05-20 7:35 ` [PATCH -V11 1/9] exportfs: Return the minimum required handle size Aneesh Kumar K.V
2010-05-21 22:15 ` J. Bruce Fields
2010-05-22 8:32 ` Aneesh Kumar K. V [this message]
2010-05-22 15:27 ` Aneesh Kumar K. V
2010-05-22 21:44 ` Neil Brown
2010-05-20 7:35 ` [PATCH -V11 2/9] vfs: Add name to file handle conversion support Aneesh Kumar K.V
2010-05-21 22:15 ` J. Bruce Fields
2010-05-22 9:04 ` Aneesh Kumar K. V
2010-05-20 7:35 ` [PATCH -V11 3/9] vfs: Add open by file handle support Aneesh Kumar K.V
2010-05-20 7:35 ` [PATCH -V11 4/9] vfs: Allow handle based open on symlinks Aneesh Kumar K.V
2010-05-20 7:35 ` [PATCH -V11 5/9] vfs: Support null pathname in readlink Aneesh Kumar K.V
2010-05-20 7:35 ` [PATCH -V11 6/9] ext4: Copy fs UUID to superblock Aneesh Kumar K.V
2010-05-20 7:35 ` [PATCH -V11 7/9] x86: Add new syscalls for x86_32 Aneesh Kumar K.V
2010-05-20 7:35 ` [PATCH -V11 8/9] x86: Add new syscalls for x86_64 Aneesh Kumar K.V
2010-05-20 7:35 ` [PATCH -V11 9/9] ext3: Copy fs UUID to superblock Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874oi02v6w.fsf@linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=adilger@sun.com \
--cc=bfields@fieldses.org \
--cc=corbet@lwn.net \
--cc=hch@infradead.org \
--cc=hooanon05@yahoo.co.jp \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=philippe.deniel@CEA.FR \
--cc=serue@us.ibm.com \
--cc=sfrench@us.ibm.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.