From: Kevin Hilman <khilman@deeprootsystems.com>
To: Jani Nikula <ext-jani.1.nikula@nokia.com>
Cc: Tomi.Valkeinen@nokia.com,
linux-fbdev-devel@lists.sourceforge.net,
linux-omap@vger.kernel.org
Subject: Re: [PATCH 1/2] OMAP: DSS2: omap_dss_probe() conditional compilation cleanup
Date: Thu, 06 May 2010 11:52:51 -0700 [thread overview]
Message-ID: <874oikvp4s.fsf@deeprootsystems.com> (raw)
In-Reply-To: <bce34ed2a9f7206ddeedb2921807c7602cfcaaaa.1273146322.git.ext-jani.1.nikula@nokia.com> (Jani Nikula's message of "Thu\, 6 May 2010 14\:59\:02 +0300")
Jani Nikula <ext-jani.1.nikula@nokia.com> writes:
> From: Jani Nikula <ext-jani.1.nikula@nokia.com>
>
> Move a number of #ifdefs from code into dss.h and elsewhere, and
> conditionally define no-op static inline functions, cleaning up the
> code. This style is according to Documentation/SubmittingPatches.
>
> Signed-off-by: Jani Nikula <ext-jani.1.nikula@nokia.com>
Indeed, this helps readability greatly.
Acked-by: Kevin Hilman <khilman@deeprootsystems.com>
next prev parent reply other threads:[~2010-05-06 18:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-06 11:59 [PATCH 0/2] OMAP: DSS2: Fix DSS core init fail path Jani Nikula
2010-05-06 11:59 ` [PATCH 1/2] OMAP: DSS2: omap_dss_probe() conditional compilation cleanup Jani Nikula
2010-05-06 18:52 ` Kevin Hilman [this message]
2010-05-06 11:59 ` [PATCH 2/2] OMAP: DSS2: Fix omap_dss_probe() error path Jani Nikula
2010-05-06 18:54 ` Kevin Hilman
2010-05-07 12:12 ` Jani Nikula
2010-05-07 8:07 ` [PATCH 0/2] OMAP: DSS2: Fix DSS core init fail path Tomi Valkeinen
2010-05-07 9:58 ` [PATCH v2 " Jani Nikula
2010-05-07 9:58 ` [PATCH v2 1/2] OMAP: DSS2: omap_dss_probe() conditional compilation cleanup Jani Nikula
2010-05-07 9:58 ` [PATCH v2 2/2] OMAP: DSS2: Fix omap_dss_probe() error path Jani Nikula
2010-05-10 7:01 ` [PATCH v2 0/2] OMAP: DSS2: Fix DSS core init fail path Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874oikvp4s.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=Tomi.Valkeinen@nokia.com \
--cc=ext-jani.1.nikula@nokia.com \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.