From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NfZzR-0003Aa-E1 for mharc-grub-devel@gnu.org; Thu, 11 Feb 2010 09:25:57 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NfZzP-00039K-H8 for grub-devel@gnu.org; Thu, 11 Feb 2010 09:25:55 -0500 Received: from [199.232.76.173] (port=59157 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NfZzP-00038t-03 for grub-devel@gnu.org; Thu, 11 Feb 2010 09:25:55 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NfZzL-0002pw-99 for grub-devel@gnu.org; Thu, 11 Feb 2010 09:25:54 -0500 Received: from mail1.asahi-net.or.jp ([202.224.39.197]:9538) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NfZzJ-0002ox-BB for grub-devel@gnu.org; Thu, 11 Feb 2010 09:25:50 -0500 Received: from rabbit.sekiba.org (x238029.ppp.asahi-net.or.jp [122.249.238.29]) by mail1.asahi-net.or.jp (Postfix) with ESMTP id ACB199B8AB for ; Thu, 11 Feb 2010 23:25:44 +0900 (JST) Date: Thu, 11 Feb 2010 23:25:44 +0900 Message-ID: <874oln97dj.wl%jir@sekiba.com> From: Jiro SEKIBA To: The development of GNU GRUB In-Reply-To: <4B71FE67.20608@gmail.com> References: <87iqae3bd0.wl%jir@sekiba.com> <4B71FE67.20608@gmail.com> User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.7 Emacs/22.3 (i486-pc-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=ISO-8859-7 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] a new filessytem module for nilfs2 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Feb 2010 14:25:55 -0000 Hi, At Wed, 10 Feb 2010 01:31:35 +0100, Vladimir '=F6-coder/phcoder' Serbinenko wrote: >=20 > Jiro SEKIBA wrote: > > Hi, > > > > This is a patch to support nilfs2 filesystem. > > I would like you to review the patch. > > > > I've checked with revno 2153 and kvm(qemu) environment. > > > > Also the patch has already an ability to boot the kernel from > > the nilfs partition, I have a following ToDo list to improve the module. > > > > 1. revision check for future disk layout changes > > 2. CRC check for superblock to ensure the partition is a nilfs2 partiti= on > > 3. CRC check latest log block to ensure valid log=20 > > 4. search the latest log in case unclean unmount happened > > > > nilfs2 stands for New Implementation of Log Filesystem version2. > > nilfs2 has been merged into linux main line kernel since 2.6.30. > > > > Please give me any comments or advice. > > > > thank you very much in advance > > =20 >=20 > +pkglib_MODULES +=3D fshelp.mod fat.mod ufs1.mod ufs2.mod ext2.mod > nilfs2.mod \ > + ntfs.mod ntfscomp.mod minix.mod hfs.mod jfs.mod iso9660.mod > xfs.mod \ >=20 > For new modules we prefer to add pkglib_MODULES+=3D directly before the > module itself > +/* ext2.c - Second Extended filesystem */ > +/* > Leftover > +#define DIV_ROUND_UP(n,d) (((n) + (d) - 1) / (d)) > This can go into misc.h > iterate_dir: > + /* Search the file. */ > + while (fpos < grub_le_to_cpu64 (diro->inode.i_size)) > + { > Another leftover > I'm no nilfs2 expert but assuming that it works it's a good patch. Have > you tested it on big-endian system? If no nd you have no access to such > send me testing instructions, I have a powerpc machine (or one can use > qemu). > Nice job Thank you very much for the reviews and comments! I'll revise the patch. Also, I'll try the patch on qemu to check for big-endian system. Thank you very much again! regards, > > ------------------------------------------------------------------------ > > > > > > =20 > > ------------------------------------------------------------------------ > > > > _______________________________________________ > > Grub-devel mailing list > > Grub-devel@gnu.org > > http://lists.gnu.org/mailman/listinfo/grub-devel > > =20 >=20 >=20 > --=20 > Regards > Vladimir '=F6-coder/phcoder' Serbinenko >=20 >=20 --=20 Jiro SEKIBA