From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MCWE9-000172-0o for mharc-grub-devel@gnu.org; Fri, 05 Jun 2009 06:00:45 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MCWE6-00016N-Ty for grub-devel@gnu.org; Fri, 05 Jun 2009 06:00:42 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MCWE2-00015f-Tf for grub-devel@gnu.org; Fri, 05 Jun 2009 06:00:42 -0400 Received: from [199.232.76.173] (port=44012 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MCWE2-00015c-NS for grub-devel@gnu.org; Fri, 05 Jun 2009 06:00:38 -0400 Received: from smtp-vbr17.xs4all.nl ([194.109.24.37]:1403) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MCWDz-0006I6-T4 for grub-devel@gnu.org; Fri, 05 Jun 2009 06:00:37 -0400 Received: from marco (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr17.xs4all.nl (8.13.8/8.13.8) with ESMTP id n55A0WpZ063173 for ; Fri, 5 Jun 2009 12:00:32 +0200 (CEST) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <1243426603.3425.2.camel@fz.local> <1243865933.3417.2.camel@fz.local> <1244043954.3407.4.camel@fz.local> <874ouwcst9.fsf@xs4all.nl> <1244191623.3416.1.camel@fz.local> Mail-Copies-To: mgerards@xs4all.nl Date: Fri, 05 Jun 2009 12:00:31 +0200 In-Reply-To: <1244191623.3416.1.camel@fz.local> (Felix Zielcke's message of "Fri, 05 Jun 2009 10:47:03 +0200") Message-ID: <874ouvxao0.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-operating-system: by monty-python.gnu.org: FreeBSD 4.6-4.9 Subject: Re: [PATCH] add true and false commands X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Jun 2009 10:00:43 -0000 Felix Zielcke writes: > Am Donnerstag, den 04.06.2009, 10:21 +0200 schrieb Marco Gerards: >> Felix Zielcke writes: >> >> > Am Montag, den 01.06.2009, 16:24 +0200 schrieb Vladimir 'phcoder' >> > Serbinenko: >> >> However convention for >> >> creating false is: >> >> return grub_error (GRUB_ERR_TEST_FAILURE, "false"); >> >> and not >> >> return 1; >> > >> > Ok changed it. If everyone is fine with placing this in normal/main.c, I >> > commit it. >> >> Unless it is essential to do so, please do not place it in >> normal/main.c. > > would normal/misc.c be okay or maybe a new file normal/true.c? > I just don't think it's worth to create a new module for these 2 very > little commands. The problem is with too many little commands, the size of normal.mod grows. Although the commands are *very* small and I do not strongly object to inclusion in normal.mod, if noone else has any objection. -- Marco