From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1MCMkh-0008To-Gu
	for mharc-grub-devel@gnu.org; Thu, 04 Jun 2009 19:53:43 -0400
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MCMke-0008Ph-2s
	for grub-devel@gnu.org; Thu, 04 Jun 2009 19:53:40 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MCMkX-0008KR-Gt
	for grub-devel@gnu.org; Thu, 04 Jun 2009 19:53:37 -0400
Received: from [199.232.76.173] (port=48124 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MCMVK-0007sV-1m
	for grub-devel@gnu.org; Thu, 04 Jun 2009 19:37:50 -0400
Received: from smtp-vbr15.xs4all.nl ([194.109.24.35]:1924)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mgerards@xs4all.nl>) id 1MC8D6-0006Z2-MM
	for grub-devel@gnu.org; Thu, 04 Jun 2009 04:22:04 -0400
Received: from marco (249-174.surfsnel.dsl.internl.net [145.99.174.249])
	by smtp-vbr15.xs4all.nl (8.13.8/8.13.8) with ESMTP id n548Lt2l078073
	for <grub-devel@gnu.org>; Thu, 4 Jun 2009 10:21:55 +0200 (CEST)
	(envelope-from mgerards@xs4all.nl)
From: Marco Gerards <mgerards@xs4all.nl>
To: The development of GRUB 2 <grub-devel@gnu.org>
References: <1243426603.3425.2.camel@fz.local>
	<d7ead6de0905300814l74dda76bwdabe2373df567b8a@mail.gmail.com>
	<1243865933.3417.2.camel@fz.local>
	<d7ead6de0906010724n30a2dcd3rb1b9c5d3553494e5@mail.gmail.com>
	<1244043954.3407.4.camel@fz.local>
Mail-Copies-To: mgerards@xs4all.nl
Date: Thu, 04 Jun 2009 10:21:54 +0200
In-Reply-To: <1244043954.3407.4.camel@fz.local> (Felix Zielcke's message of
	"Wed, 03 Jun 2009 17:45:54 +0200")
Message-ID: <874ouwcst9.fsf@xs4all.nl>
User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Virus-Scanned: by XS4ALL Virus Scanner
X-detected-operating-system: by monty-python.gnu.org: FreeBSD 4.6-4.9
Subject: Re: [PATCH] add true and false commands
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Jun 2009 23:53:41 -0000

Felix Zielcke <fzielcke@z-51.de> writes:

> Am Montag, den 01.06.2009, 16:24 +0200 schrieb Vladimir 'phcoder'
> Serbinenko:
>> However convention for
>> creating false is:
>>   return grub_error (GRUB_ERR_TEST_FAILURE, "false");
>> and not
>>   return 1;
>
> Ok changed it. If everyone is fine with placing this in normal/main.c, I
> commit it.

Unless it is essential to do so, please do not place it in
normal/main.c.

--
Marco