Re: [PATCH] mac80211: calculate maximum sleep interval

[Kalle Valo <kalle.valo@iki.fi>]

Johannes Berg <johannes@sipsolutions.net> writes:

> The maximum sleep interval, for powersave purposes, is
> determined by the DTIM period (it may not be larger)
> and the required networking latency (it must be small
> enough to fulfil those constraints).
>
> This makes mac80211 calculate the maximum sleep interval
> based on those constraints, and pass it to the driver.
> Then the driver should instruct the device to sleep at
> most that long.

I like this, just one comment:

> + * @max_sleep_interval: the maximum number of beacon intervals to sleep for
> + *	before checking the beacon for a TIM bit (managed mode only); this
> + *	value will be only achievable between DTIM frames, the hardware
> + *	needs to check for the multicast traffic bit in DTIM beacons.
> + *	This variable is valid only when the CONF_PS flag is set.

I would prefer to call it max_sleep_period. Or maybe even wakeup period,
because it's about waking up here.

For me interval, for example beacon interval, means that the unit is TU.
But this might be just me.

-- 
Kalle Valo