Re: [Qemu-devel] [PATCH 8/9] New option -audio as a more flexible alternative to -soundhw

[Markus Armbruster <armbru@redhat.com>]

Kevin Wolf <kwolf@suse.de> writes:

> Markus Armbruster schrieb:
>> Kevin Wolf <kwolf@suse.de> writes:
>> 
>>> Markus Armbruster schrieb:
>>>> malc <av1474@comtv.ru> writes:
>>>>
>>>>> On Thu, 22 Jan 2009, Markus Armbruster wrote:
>>>>>
>>>>>> From: Markus Armbruster <armbru@pond.sub.org>
>>>>>>
>>>>>> This is in preparation of pci=... support for audio devices.  -soundhw
>>>>>> doesn't support the common name=value,... syntax.
>>>>>> ---
>>>>>> sysemu.h |    1 +
>>>>>> vl.c     |   94 ++++++++++++++++++++++++++++++++++++++++++++-----------------
>>>>>> 2 files changed, 69 insertions(+), 26 deletions(-)
>>>>> This as, i guess, the rest of the patches is tab damaged. The
>>>>> documentation wasn't updated either.
>>>>>
>>>>> [..snip..]
>>>> It's just a sketch.  How would you like your tabs?
>>> Probably four spaces, just like in the surrounding code (as almost
>>> everywhere in qemu).
>>>
>>> Kevin
>> 
>> Can't see where I got that wrong.
>> 
>> Any preference on use of the tab character?
>
> Most of the qemu code only uses spaces, no real tabs.
>
> Kevin

I didn't bother to avoid tabs, because I found them in existing code.
But I can certainly avoid them.  Thanks!