From: "Markus Klotzbücher" <mk@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] [PATCH] Fix "usb part" command
Date: Thu, 10 Jul 2008 12:14:06 +0200 [thread overview]
Message-ID: <874p6y2gi9.fsf@denx.de> (raw)
In-Reply-To: <20080709212744.3A72E24304@gemini.denx.de> (Wolfgang Denk's message of "Wed\, 09 Jul 2008 23\:27\:44 +0200")
Wolfgang Denk <wd@denx.de> writes:
> In message <121458881184-git-send-email-ceggers@gmx.de> you wrote:
>> From: Christian Eggers <christian@p2400.wgnetz.xx>
>>
>> Only print partition for selected device if user supplied the <dev> arg with the "usb part [dev]" command.
>
> What is the rationale of this modification, i. e. which bug are you
> fixing?
I think this fix is correct. If I do
usb part
U-Boot (correcly) prints the partitions of all devices. If I type
usb part 0
i only want the partitions on device 0. Without this patch I still get
all partitions on all devices. This is wrong.
> I think current behaviour is consistent between "ide part", "scsi
> part", "usb part" etc. so if there is a problem here this might need
> to be changed elsewhere, too ?
I just took a look at cmd_ide, and AFAICS it does exactly what USB will
do with this patch.
Best regards
Markus Klotzbuecher
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
next prev parent reply other threads:[~2008-07-10 10:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-27 17:46 [U-Boot-Users] [PATCH] [PATCH] Fix "usb part" command Christian Eggers
2008-07-09 21:27 ` Wolfgang Denk
2008-07-10 10:14 ` Markus Klotzbücher [this message]
2008-07-10 10:25 ` Wolfgang Denk
2008-07-10 10:14 ` Markus Klotzbücher
2008-07-10 10:25 ` Wolfgang Denk
2008-07-10 10:24 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874p6y2gi9.fsf@denx.de \
--to=mk@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.