From: Peter Korsgaard <jacmet@sunsite.dk>
To: Greg KH <greg@kroah.com>
Cc: linuxppc-dev@ozlabs.org, dbrownell@users.sourceforge.net,
stern@rowland.harvard.edu, linux-usb@vger.kernel.org
Subject: Re: [patch v7 3/4] USB: add Cypress c67x00 OTG controller HCD driver
Date: Wed, 20 Feb 2008 17:57:06 +0100 [thread overview]
Message-ID: <874pc3efbx.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <20080220161608.GE2658@kroah.com> (Greg KH's message of "Wed\, 20 Feb 2008 08\:16\:08 -0800")
>>>>> "Greg" == Greg KH <greg@kroah.com> writes:
Hi,
Greg> I don't know, I selected the config option, and yet, it built
Greg> as if it wasn't set.
Sorry, I cannot reproduce that here. Could you try again?
Greg> Can you move the files under the hcd/ subdir
Sorry, I don't think that's a good idea as the hardware can do
peripheral as well, and as you can see in patch 4, a gadget driver is
on it's way.
Greg> run it through checkpatch.pl and fix up the __FUNCTION__
Greg> warnings, and then I'll be willing to test it again :)
Ahh, that seems to be a pretty new warning in checkpatch - I atleast
haven't seen it before. The other things it complains about seems to
be rubbish though (except for the single indented label).
I'll send a v9 series shortly.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2008-02-20 16:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-19 15:09 [patch v7 0/4] Cypress c67x00 (EZ-Host/EZ-OTG) support Peter Korsgaard
2008-02-19 15:09 ` [patch v7 1/4] USB: add Cypress c67x00 low level interface code Peter Korsgaard
2008-02-19 15:09 ` [patch v7 2/4] USB: add Cypress c67x00 OTG controller core driver Peter Korsgaard
2008-02-19 15:09 ` [patch v7 3/4] USB: add Cypress c67x00 OTG controller HCD driver Peter Korsgaard
2008-02-19 23:55 ` Greg KH
2008-02-20 9:01 ` Peter Korsgaard
2008-02-20 16:16 ` Greg KH
2008-02-20 16:57 ` Peter Korsgaard [this message]
2008-02-20 17:03 ` Greg KH
2008-02-20 18:07 ` David Brownell
2008-02-20 18:29 ` Greg KH
2008-02-20 19:25 ` Peter Korsgaard
2008-02-19 15:09 ` [patch v7 4/4] USB: add Cypress c67x00 OTG controller gadget driver Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874pc3efbx.fsf@macbook.be.48ers.dk \
--to=jacmet@sunsite.dk \
--cc=dbrownell@users.sourceforge.net \
--cc=greg@kroah.com \
--cc=linux-usb@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.