From: Sergei Organov <osv@javad.com>
To: git@vger.kernel.org
Cc: Alexandre Julliard <julliard@winehq.org>, gitster@pobox.com
Subject: [PATCH] git.el: automatically revert emacs buffers
Date: Mon, 21 Jan 2008 21:07:59 +0300 [thread overview]
Message-ID: <874pcnh4ej.fsf@osv.gnss.ru> (raw)
If new custom variable git-auto-revert is 't', after git-revert-file,
revert corresponding emacs buffers from reverted files provided the
buffers were not changed. This is how pcl-cvs behaves.
* git-auto-revert: new customizable variable.
* git-revert-some-buffers: new function.
* git-revert-file: call git-revert-some-buffers.
Signed-off-by: Sergei Organov <osv@javad.com>
---
contrib/emacs/git.el | 23 +++++++++++++++++++++++
1 files changed, 23 insertions(+), 0 deletions(-)
diff --git a/contrib/emacs/git.el b/contrib/emacs/git.el
index d8a0638..c3c0c45 100644
--- a/contrib/emacs/git.el
+++ b/contrib/emacs/git.el
@@ -112,6 +112,11 @@ if there is already one that displays the same directory."
:group 'git
:type 'boolean)
+(defcustom git-auto-revert t
+ "Non-nil if `git-revert-file' should automatically revert corresponding buffers."
+ :group 'git
+ :type 'boolean)
+
(defface git-status-face
'((((class color) (background light)) (:foreground "purple"))
@@ -989,6 +994,23 @@ Return the list of files that haven't been handled."
(git-success-message "Removed" files))
(message "Aborting"))))
+;; stolen from pcl-cvs's cvs-revert-if-needed
+(defun git-revert-some-buffers (fis)
+ (dolist (fileinfo fis)
+ (let* ((file (git-fileinfo->name fileinfo))
+ (buffer (find-buffer-visiting file)))
+ ;; For a revert to happen the user must be editing the file...
+ (unless (or (null buffer)
+ (buffer-modified-p buffer))
+ (with-current-buffer buffer
+ (ignore-errors
+ (revert-buffer 'ignore-auto 'dont-ask 'preserve-modes)
+ ;; `preserve-modes' avoids changing the (minor) modes. But we
+ ;; do want to reset the mode for VC, so we do it explicitly.
+ (vc-find-file-hook)
+ (when (eq (git-fileinfo->state fileinfo) 'unmerged)
+ (smerge-mode 1))))))))
+
(defun git-revert-file ()
"Revert changes to the marked file(s)."
(interactive)
@@ -1008,6 +1030,7 @@ Return the list of files that haven't been handled."
(when modified
(apply #'git-call-process-env nil nil "checkout" "HEAD" modified))
(git-update-status-files (append added modified) 'uptodate)
+ (if git-auto-revert (git-revert-some-buffers files))
(git-success-message "Reverted" (git-get-filenames files)))))
(defun git-resolve-file ()
--
1.5.4.18.gd0b8
next reply other threads:[~2008-02-05 14:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-21 18:07 Sergei Organov [this message]
2008-02-07 12:57 ` [PATCH] git.el: automatically revert emacs buffers Alexandre Julliard
2008-02-07 13:03 ` Sergei Organov
-- strict thread matches above, loose matches on Subject: below --
2008-01-21 18:07 Sergei Organov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874pcnh4ej.fsf@osv.gnss.ru \
--to=osv@javad.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=julliard@winehq.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.