From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JM3eF-0006gj-BE for mharc-grub-devel@gnu.org; Mon, 04 Feb 2008 10:54:19 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JM3eD-0006du-Mi for grub-devel@gnu.org; Mon, 04 Feb 2008 10:54:17 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JM3eA-0006YK-Te for grub-devel@gnu.org; Mon, 04 Feb 2008 10:54:17 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JM3eA-0006Y7-Lw for grub-devel@gnu.org; Mon, 04 Feb 2008 10:54:14 -0500 Received: from smtp-vbr6.xs4all.nl ([194.109.24.26]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JM3eA-0005sp-K8 for grub-devel@gnu.org; Mon, 04 Feb 2008 10:54:14 -0500 Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr6.xs4all.nl (8.13.8/8.13.8) with ESMTP id m14FsCDe004028 for ; Mon, 4 Feb 2008 16:54:13 +0100 (CET) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <1202074413.560.7.camel@k9.localnet> Mail-Copies-To: mgerards@xs4all.nl Date: Mon, 04 Feb 2008 16:56:01 +0100 In-Reply-To: <1202074413.560.7.camel@k9.localnet> (wa1ter@myrealbox.com's message of "Sun, 03 Feb 2008 13:33:33 -0800") Message-ID: <874pco90mm.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.6-4.9 Subject: Re: [PATCH] to make grub2 compile on NetBSD X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Feb 2008 15:54:18 -0000 walt writes: > NetBSD's gcc wants libgcc and libc to define __enable_execute_stack, > but this is useless for a free-standing executable like grub. Define > a dummy function in lieu of libgcc to supply __enable_execute_stack. Great, thanks! Can you send in a changelog entry? > Index: include/grub/mm.h > =================================================================== > RCS file: /sources/grub/grub2/include/grub/mm.h,v > retrieving revision 1.8 > diff -u -r1.8 mm.h > --- include/grub/mm.h 21 Jul 2007 23:32:22 -0000 1.8 > +++ include/grub/mm.h 3 Feb 2008 21:24:18 -0000 > @@ -33,6 +33,7 @@ > void EXPORT_FUNC(grub_free) (void *ptr); > void *EXPORT_FUNC(grub_realloc) (void *ptr, grub_size_t size); > void *EXPORT_FUNC(grub_memalign) (grub_size_t align, grub_size_t size); > +void EXPORT_FUNC(__enable_execute_stack) (void); /* For NetBSD gcc */ Please use our style of commenting. So a `.' followed by two spaces. Better put this on a separate line. If this is for NetBSD only, shouldn't you add a #ifdef instead of a comment? > /* For debugging. */ > #if defined(MM_DEBUG) && !defined(GRUB_UTIL) > Index: kern/mm.c > =================================================================== > RCS file: /sources/grub/grub2/kern/mm.c,v > retrieving revision 1.19 > diff -u -r1.19 mm.c > --- kern/mm.c 23 Jan 2008 14:57:40 -0000 1.19 > +++ kern/mm.c 3 Feb 2008 21:24:19 -0000 > @@ -66,6 +66,12 @@ > #include > #include > > +/* Dummy symbol to make NetBSD gcc happy */ > +void > +__enable_execute_stack(void) > +{ > +} > + > #ifdef MM_DEBUG > # undef grub_malloc > # undef grub_realloc > > > > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel