From: Marco Gerards <mgerards@xs4all.nl>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] safety check in claim_heap()
Date: Mon, 21 Jan 2008 22:11:42 +0100 [thread overview]
Message-ID: <874pd6994h.fsf@xs4all.nl> (raw)
In-Reply-To: <20080121210112.GB15119@thorin> (Robert Millan's message of "Mon, 21 Jan 2008 22:01:12 +0100")
Robert Millan <rmh@aybabtu.com> writes:
> On Mon, Jan 21, 2008 at 07:07:37PM +0100, Marco Gerards wrote:
>> Robert Millan <rmh@aybabtu.com> writes:
>>
>> Hi,
>>
>> > What do you think of adding this kind of checks? I know it's not a
>> > perfect safegard, but it can save your day in some situations (it helped
>> > me during i386/ieee1275 port, when link address was 0x100000).
>>
>> If this fixes the i386-ieee1275 port, this is fine to me.
>
> It isn't currently needed by either of the i386-ieee1275 targets (qemu and
> xo).
>
> However, it was during an earlier stage of the port in which link address
> was 0x100000 rather than 0x10000.
>
> My question is whether it makes sense as a general safety check.
Well, if it isn't going to occur with the current firmware
implementations, I do not see the use. But it will not hurt either.
Simply, I do not care either way... I leave this up to you ;-)
--
Marco
next prev parent reply other threads:[~2008-01-21 21:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-20 14:22 [PATCH] safety check in claim_heap() Robert Millan
2008-01-21 18:07 ` Marco Gerards
2008-01-21 21:01 ` Robert Millan
2008-01-21 21:11 ` Marco Gerards [this message]
2008-01-22 20:09 ` Robert Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874pd6994h.fsf@xs4all.nl \
--to=mgerards@xs4all.nl \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.