Re: [PATCH v2] Make fetch-pack a builtin with an internal API

[Florian Weimer <fw@deneb.enyo.de>]

* Theodore Tso:

> On Mon, Jul 09, 2007 at 02:16:35PM +0100, Andy Parkins wrote:

>> Perhaps I'm reading it wrong but:
>> 
>> "All identifiers beginning with an underscore are reserved for ordinary 
>> identifiers (functions, variables, typedefs, enumeration constants) with file 
>                                                                       ^^^^^^^^^
>> scope."
>   ^^^^^^
>> 
>> Doesn't agree with what you've said.  I think that you _can_ use _[a-z]* for 
>> labels or structure members - however, not within file or function scope.
>
> I think the above does agree with what I said.  It says that you can
> use functions, variables, typdefs, enumeration constants (not just
> labels or structure members) WITH FILE SCOPE.

No, they are are reserved.

> I.e., so long as it doesn't leak across a .o linkage.  So one .o
> file can use a static _my_strdup, and another .o file can use a
> static _my_strdup, and they don't have to worry about multiply
> defined function conflicts, since they are static functions with
> file or smaller scoping.

This is not sufficient because the implementation might have a
*typedef* for _my_strdup in any header file, and neither translation
unit would compile.  Or they could have been declared with a different
prototype.