From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1HowZ0-0002Iz-JS for mharc-grub-devel@gnu.org; Fri, 18 May 2007 03:07:46 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HowYz-0002Ir-UZ for grub-devel@gnu.org; Fri, 18 May 2007 03:07:45 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HowYx-0002IX-L7 for grub-devel@gnu.org; Fri, 18 May 2007 03:07:44 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HowYx-0002IU-En for grub-devel@gnu.org; Fri, 18 May 2007 03:07:43 -0400 Received: from smtp-vbr6.xs4all.nl ([194.109.24.26]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HowQj-000587-W7 for grub-devel@gnu.org; Fri, 18 May 2007 02:59:15 -0400 Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr6.xs4all.nl (8.13.8/8.13.8) with ESMTP id l4I6x63Q035958 for ; Fri, 18 May 2007 08:59:06 +0200 (CEST) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <87d50z2l8z.fsf@xs4all.nl> <20070518064837.GC1783@aragorn> Mail-Copies-To: mgerards@xs4all.nl Date: Fri, 18 May 2007 08:59:45 +0200 In-Reply-To: <20070518064837.GC1783@aragorn> (Robert Millan's message of "Fri, 18 May 2007 08:48:37 +0200") Message-ID: <874pma39cu.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-kernel: FreeBSD 4.6-4.9 Subject: Re: Host filesystem access X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 May 2007 07:07:46 -0000 Robert Millan writes: > On Thu, May 17, 2007 at 11:28:12PM +0200, Marco Gerards wrote: >> + grub_error (GRUB_ERR_BAD_FS, "not a affs filesystem"); >> + grub_error (GRUB_ERR_BAD_FS, "not a hfsplus filesystem"); >> + grub_error (GRUB_ERR_BAD_FS, "not a sfs filesystem"); > > I think these should be "an" (but not sure about all them, any native English > speaker around?). Ehm, yes, I think so :-) >> diff -u -p -u -p -r1.34 grub-emu.c >> --- util/grub-emu.c 16 May 2007 21:38:44 -0000 1.34 >> +++ util/grub-emu.c 17 May 2007 21:17:02 -0000 >> @@ -185,6 +185,8 @@ main (int argc, char *argv[]) >> /* XXX: This is a bit unportable. */ >> grub_util_biosdisk_init (args.dev_map); >> >> + grub_hostfs_init (); >> + >> grub_init_all (); > > I find it counter-intuitive that grub_init_all doesn't imply grub_hostfs_init; > if there's a design reason for this, maybe the function should be renamed ? > (how about grub_filesystems_init + grub_partmaps_init ?) The reason why I did this is that hostfs is not a module. grub_init_all initializes all modules, there is no way you can split this up in an easy way. The main thing I had some doubts on was if the dummy disk driver is way too ugly or not. -- Marco