From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1E4z4v-0005Nr-Vo for mharc-grub-devel@gnu.org; Tue, 16 Aug 2005 06:53:59 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1E4z4n-0005Mn-Bj for grub-devel@gnu.org; Tue, 16 Aug 2005 06:53:50 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1E4z4j-0005M8-7e for grub-devel@gnu.org; Tue, 16 Aug 2005 06:53:46 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1E4ypP-00027f-GA for grub-devel@gnu.org; Tue, 16 Aug 2005 06:37:55 -0400 Received: from [145.74.66.11] (helo=mail-cn.han.nl) by monty-python.gnu.org with esmtp (Exim 4.34) id 1E4yYO-0000kG-S0 for grub-devel@gnu.org; Tue, 16 Aug 2005 06:20:21 -0400 Received: from vscan-cn.han.nl (venus.han.nl [145.74.65.6]) by mail-cn.han.nl (Postfix) with ESMTP id 75E238849 for ; Tue, 16 Aug 2005 12:04:21 +0200 (CEST) Received: from mail-cn.han.nl ([145.74.66.11]) by vscan-cn.han.nl (venus.han.nl [145.74.65.6]) (amavisd-new, port 10024) with ESMTP id 05719-02 for ; Tue, 16 Aug 2005 12:04:19 +0200 (CEST) Received: from mail1.han.nl (mail1.han.nl [145.74.103.11]) by mail-cn.han.nl (Postfix) with ESMTP id 1BC0987BA for ; Tue, 16 Aug 2005 12:04:19 +0200 (CEST) Received: from localhost.localdomain (mgerards.xs4all.nl [82.92.27.129]) by mail1.han.nl (Postfix) with ESMTP id 76C29C046 for ; Tue, 16 Aug 2005 12:04:18 +0200 (CEST) Mail-Copies-To: metgerards@student.han.nl To: The development of GRUB 2 References: <42FF3097.7030904@nic.fi> <87zmrjxge4.fsf@student.han.nl> <430103AD.1090800@nic.fi> <87acjivquh.fsf@student.han.nl> <43010B92.3030900@nic.fi> From: Marco Gerards Date: Tue, 16 Aug 2005 12:04:18 +0200 In-Reply-To: <43010B92.3030900@nic.fi> ( =?iso-8859-1?q?Vesa_J=E4=E4skel=E4inen's_message_of?= "Tue, 16 Aug 2005 00:39:30 +0300") Message-ID: <874q9qnqot.fsf@student.han.nl> User-Agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Virus-Scanned: by amavisd-new (2.2.0) at vscan-cn.han.nl Subject: Re: vesafb terminal for testing. X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Aug 2005 10:53:53 -0000 Vesa J=E4=E4skel=E4inen writes: > Marco Gerards wrote: >> Vesa J=E4=E4skel=E4inen writes: >>=20 >>>> There are some long lines, can you please make them shorter so >>>> the maximal line length is 78 characters? >>> Hmm... I made another scan for those. Still I left some of those there >>> because in my opinion it is much more readable in that way. But splitted >>> some lines. >>=20 >> Can you should me which so I can come up with a suggestion? > > video/i386/pc/vbe.c: > - setpixel functions. There are couple of "too" long lines. > - grub_vbe_get_video_mode_info first variable definition is a bit long. grub_uint32_t *ptr =3D (grub_uint32_t *)(framebuffer + y * bytes_per_= scan_line + x * 4); This can be changed in: grub_uint32_t *ptr; ptr =3D (grub_uint32_t *)(framebuffer + y * bytes_per_scan_line + x *= 4); or: grub_uint32_t *ptr =3D (grub_uint32_t *)(framebuffer + y * bytes_per_scan_line + x * 4); > term/i386/pc/vesafb.c: > - grub_virtual_screen_setup, grub_malloc line. You fixed this already. Please put operators on the beginning of the next line instead of the end of the line. > - write_char, set pixel line at end. How about: grub_vbe_set_pixel_index(i + (virtual_screen.cursor_x * virtual_screen.char_width), y + (virtual_screen.cursor_y * virtual_screen.char_height), color); > - grub_virtual_screen_setcolor, function definition. This is a tough one, but not important I guess. :) > commands/i386/pc/vbe_test.c: > - GRUB_MOD_INIT. You can split the line after the commas. > commands/i386/pc/vbe_list_modes.c: > - GRUB_MOD_INIT. Same here. > include/grub/i386/pc/vbe.h: > - several function prototypes. You could try to split the line after the commas for the arguments. Sometimes it is not possible to create a shorter line and in that case it is not important. >>> I will scan the code once more and then commit a bit different version >>> to CVS as Okuji asked to commit it to there for easier testing. > > Just a note until admins fix those commit messages, first version of vbe > terminal support is now committed. It still needs more work, but it is a > starting point. Cool! If you do receive the commit messages, can you forward them so we could see them as well? Thanks, Marco