From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by monty-python.gnu.org with archive (Exim 4.34) id 1BPQbD-00018G-GR for mharc-grub-devel@gnu.org; Sun, 16 May 2004 14:42:59 -0400 Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.34) id 1BPQaq-0000kJ-M9 for grub-devel@gnu.org; Sun, 16 May 2004 14:42:36 -0400 Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.34) id 1BPQaF-0000GJ-SW for grub-devel@gnu.org; Sun, 16 May 2004 14:42:32 -0400 Received: from [145.74.66.11] (helo=mail-cn.han.nl) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BPQaF-0000Ft-Dd for grub-devel@gnu.org; Sun, 16 May 2004 14:41:59 -0400 Received: from localhost (charlie.han.nl [145.74.66.9]) by mail-cn.han.nl (Postfix) with ESMTP id 9E219874B for ; Sun, 16 May 2004 20:41:47 +0200 (CEST) Received: from mail-cn.han.nl ([145.74.66.11]) by localhost (charlie.han.nl [145.74.66.9]) (amavisd-new, port 10024) with ESMTP id 14033-03 for ; Sun, 16 May 2004 20:41:45 +0200 (CEST) Received: from mail1.han.nl (mail1.han.nl [145.74.103.11]) by mail-cn.han.nl (Postfix) with ESMTP id BEA51865D for ; Sun, 16 May 2004 20:41:45 +0200 (CEST) Received: from marco.marco-g.com (a82-92-27-129.adsl.xs4all.nl [82.92.27.129]) by mail1.han.nl (Postfix) with ESMTP id 410EFC048 for ; Sun, 16 May 2004 19:41:45 +0200 (CEST) Mail-Copies-To: metgerards@student.han.nl To: The development of GRUB 2 References: <200405160119.11048.shivramk@sancharnet.in> <87y8ntzbmb.fsf@marco.marco-g.com> <20040516163441.GD22889@openbios.org> From: Marco Gerards Date: Sun, 16 May 2004 20:44:03 +0200 In-Reply-To: <20040516163441.GD22889@openbios.org> (Stefan Reinauer's message of "Sun, 16 May 2004 18:34:41 +0200") Message-ID: <874qqgfc0c.fsf@marco.marco-g.com> User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by amavisd-new@vscan-cn.han.nl Subject: Re: Issues in implementing VESA support X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 May 2004 18:42:55 -0000 Stefan Reinauer writes: > * Marco Gerards [040515 22:19]: >> If there are no copyright issues, you can just copy them. I am not >> sure if the person that wrote that code assigned his copyrights to the >> FSF. If you know that, just copy it. Otherwise Okuji can tell us. > > Why would the FSF need the copyright for that piece of code? It being > GPL would be enough to make it usable in a new GPL project like grub2 is. There is something written about the copyright assignments in the GCS: http://www.gnu.org/prep/standards_4.html#SEC4 I am not sure about how Okuji wants to handle copyrights, but IIRC for GRUB 2 those need to be assigned. Anyway, this should not be a too big issue. >> > 3. If i have more than one file then should i put them in a separate >> > driectory? If yes where (under term ) ? >> >> It should go into grub2/term/i386/pc. It depends on how many files >> you need to descide if a new directory should be created. I think you >> can better do what seems the best to you. Changing this later should >> not be a problem, right? > > The hardware/VESA specific code should go below i386/pc. Any code that > can generically be reused for other machines should be placed in a > generic location. Changing this later will pretty much end up in a mess. > The file hierarchy should be an illustration of the logical program > structure. Moving the structure of the code around will end up in a > similar mess as grub 0.x This is not what I meant. What I meant was that I we can discuss that when we have a patch. I'd be happy to review the patch and move things around before applying it. You are right about the generic code, it should be shared. For example the powerbooks from apple have a graphical framebuffer at startup. For example the code load pictures for the background (assuming that will, be done) can be shared, just like the font code. Thanks, Marco