All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: dhowells@redhat.com, John Hubbard <jhubbard@nvidia.com>,
	Al Viro <viro@zeniv.linux.org.uk>,
	Christoph Hellwig <hch@infradead.org>,
	Matthew Wilcox <willy@infradead.org>,
	Jens Axboe <axboe@kernel.dk>, Jan Kara <jack@suse.cz>,
	Jeff Layton <jlayton@kernel.org>,
	Logan Gunthorpe <logang@deltatee.com>,
	linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
	linux-mm@kvack.org
Subject: Re: [PATCH v8 10/10] mm: Renumber FOLL_PIN and FOLL_GET down
Date: Tue, 24 Jan 2023 14:59:25 +0000	[thread overview]
Message-ID: <875206.1674572365@warthog.procyon.org.uk> (raw)
In-Reply-To: <Y8/rx6PQ4z9Tk8qQ@nvidia.com>

Jason Gunthorpe <jgg@nvidia.com> wrote:

> What is the 3rd state?

Consider a network filesystem message generated for a direct I/O that the
network filesystem does zerocopy on.  You may have an sk_buff that has
fragments from one or more of three different sources:

 (1) Fragments consisting of specifically allocated pages, such as the
     IP/UDP/TCP headers that have refs taken on them.

 (2) Fragments consisting of zerocopy kernel buffers that has neither refs nor
     pins belonging to the sk_buff.

     iov_iter_extract_pages() will not take pins when extracting from, say, an
     XARRAY-type or KVEC-type iterator.  iov_iter_extract_mode() will return
     0.

 (3) Fragments consisting of zerocopy user buffers that have pins taken on
     them belonging to the sk_buff.

     iov_iter_extract_pages() will take pins when extracting from, say, a
     UBUF-type or IOVEC-type iterator.  iov_iter_extract_mode() will return
     FOLL_PIN (at the moment).

So you have three states: Ref'd, pinned and no-retention.

David


  reply	other threads:[~2023-01-24 15:00 UTC|newest]

Thread overview: 75+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-23 17:29 [PATCH v8 00/10] iov_iter: Improve page extraction (pin or just list) David Howells
2023-01-23 17:29 ` [PATCH v8 01/10] iov_iter: Define flags to qualify page extraction David Howells
2023-01-23 18:20   ` Christoph Hellwig
2023-01-24  2:12   ` John Hubbard
2023-01-23 17:29 ` [PATCH v8 02/10] iov_iter: Add a function to extract a page list from an iterator David Howells
2023-01-23 18:21   ` Christoph Hellwig
2023-01-24 14:27   ` David Hildenbrand
2023-01-24 14:35     ` David Howells
2023-01-24 14:37       ` David Hildenbrand
2023-01-24 14:45         ` David Howells
2023-01-24 14:52           ` David Hildenbrand
2023-01-23 17:30 ` [PATCH v8 03/10] mm: Provide a helper to drop a pin/ref on a page David Howells
2023-01-23 18:21   ` Christoph Hellwig
2023-01-24  3:03   ` John Hubbard
2023-01-24 14:28   ` David Hildenbrand
2023-01-24 14:41     ` David Howells
2023-01-24 14:52       ` Christoph Hellwig
2023-01-24 14:53         ` David Hildenbrand
2023-01-24 15:04         ` David Howells
2023-01-23 17:30 ` [PATCH v8 04/10] iomap: don't get an reference on ZERO_PAGE for direct I/O block zeroing David Howells
2023-01-23 18:22   ` Christoph Hellwig
2023-01-24  2:42   ` John Hubbard
2023-01-24  5:59     ` Christoph Hellwig
2023-01-24  7:03       ` John Hubbard
2023-01-24 14:29   ` David Hildenbrand
2023-01-23 17:30 ` [PATCH v8 05/10] block: Fix bio_flagged() so that gcc can better optimise it David Howells
2023-01-23 17:30 ` [PATCH v8 06/10] block: Rename BIO_NO_PAGE_REF to BIO_PAGE_REFFED and invert the meaning David Howells
2023-01-23 18:23   ` Christoph Hellwig
2023-01-23 17:30 ` [PATCH v8 07/10] block: Switch to pinning pages David Howells
2023-01-23 18:23   ` Christoph Hellwig
2023-01-24 14:32   ` David Hildenbrand
2023-01-24 14:47     ` David Howells
2023-01-24 14:53       ` Christoph Hellwig
2023-01-24 15:03         ` David Howells
2023-01-24 16:44           ` Christoph Hellwig
2023-01-24 16:46             ` David Hildenbrand
2023-01-24 18:38               ` David Howells
2023-01-24 16:59             ` Christoph Hellwig
2023-01-24 18:37               ` David Howells
2023-01-24 18:55                 ` Christoph Hellwig
2023-01-23 17:30 ` [PATCH v8 08/10] block: Convert bio_iov_iter_get_pages to use iov_iter_extract_pages David Howells
2023-01-23 18:23   ` Christoph Hellwig
2023-01-23 17:30 ` [PATCH v8 09/10] block: convert bio_map_user_iov " David Howells
2023-01-23 18:24   ` Christoph Hellwig
2023-01-23 17:30 ` [PATCH v8 10/10] mm: Renumber FOLL_PIN and FOLL_GET down David Howells
2023-01-23 18:25   ` Christoph Hellwig
2023-01-24  3:08   ` John Hubbard
2023-01-24  3:11     ` John Hubbard
2023-01-24 13:13       ` Jason Gunthorpe
2023-01-24 13:18         ` Christoph Hellwig
2023-01-24 13:43           ` Jason Gunthorpe
2023-01-24 13:40         ` David Howells
2023-01-24 13:46         ` David Howells
2023-01-24 13:47           ` Jason Gunthorpe
2023-01-24 13:57             ` David Howells
2023-01-24 14:00               ` Jason Gunthorpe
2023-01-24 14:11                 ` David Howells
2023-01-24 14:14                   ` Jason Gunthorpe
2023-01-24 14:27                     ` David Howells
2023-01-24 14:31                       ` Jason Gunthorpe
2023-01-24 14:59                         ` David Howells [this message]
2023-01-24 15:06                           ` Jason Gunthorpe
2023-01-24 15:12                             ` David Howells
2023-01-24 14:02               ` Christoph Hellwig
2023-01-24 14:12                 ` David Howells
2023-01-24 14:13                   ` Christoph Hellwig
2023-01-24 14:25                     ` David Howells
2023-01-24  7:05     ` David Howells
2023-01-24  2:02 ` [PATCH v8 00/10] iov_iter: Improve page extraction (pin or just list) John Hubbard
2023-01-24 12:44 ` David Hildenbrand
2023-01-24 13:16   ` Christoph Hellwig
2023-01-24 13:22     ` David Hildenbrand
2023-01-24 13:32       ` Christoph Hellwig
2023-01-24 13:35         ` David Hildenbrand
2023-01-24 13:44   ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875206.1674572365@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=hch@infradead.org \
    --cc=hch@lst.de \
    --cc=jack@suse.cz \
    --cc=jgg@nvidia.com \
    --cc=jhubbard@nvidia.com \
    --cc=jlayton@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=logang@deltatee.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.