From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jakob Bornecrantz <jakob@vmware.com>
Subject: Re: [PATCH] drm/ttm: Don't clear page metadata of imported sg pages
Date: Wed, 5 Feb 2014 06:37:25 -0800 (PST)
Message-ID: <875572983.13196562.1391611045498.JavaMail.root@vmware.com>
References: <1391589243-10467-1-git-send-email-thellstrom@vmware.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from smtp-outbound-1.vmware.com (smtp-outbound-1.vmware.com
	[208.91.2.12])
	by gabe.freedesktop.org (Postfix) with ESMTP id E258E40D5
	for <dri-devel@lists.freedesktop.org>;
	Wed,  5 Feb 2014 06:37:26 -0800 (PST)
Received: from sc9-mailhost3.vmware.com (sc9-mailhost3.vmware.com
	[10.113.161.73])
	by smtp-outbound-1.vmware.com (Postfix) with ESMTP id 5E6072834D
	for <dri-devel@lists.freedesktop.org>;
	Wed,  5 Feb 2014 06:37:26 -0800 (PST)
Received: from zcs-prod-mta-1.vmware.com (zcs-prod-mta-1.vmware.com
	[10.113.163.63])
	by sc9-mailhost3.vmware.com (Postfix) with ESMTP id 5CD9440242
	for <dri-devel@lists.freedesktop.org>;
	Wed,  5 Feb 2014 06:37:26 -0800 (PST)
In-Reply-To: <1391589243-10467-1-git-send-email-thellstrom@vmware.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces@lists.freedesktop.org
Errors-To: dri-devel-bounces@lists.freedesktop.org
To: Thomas Hellstrom <thellstrom@vmware.com>
Cc: dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

----- Ursprungligt meddelande -----
> These page pointers shouldn't be visible to TTM in the first place, but
> until we fix that up, don't clear the page metadata because that
> will upset the exporter.
> 
> Reported-by: Cristoph Haag <haagch.christoph@googleemail.com>
> Signed-off-by: Thomas Hellstrom <thellstrom@vmware.com>
> ---
>  drivers/gpu/drm/ttm/ttm_tt.c |    3 +++
>  1 file changed, 3 insertions(+)

Reviewed-by: Jakob Bornecrantz <jakob@vmware.com>

> 
> diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c
> index 9af9908..75f3190 100644
> --- a/drivers/gpu/drm/ttm/ttm_tt.c
> +++ b/drivers/gpu/drm/ttm/ttm_tt.c
> @@ -380,6 +380,9 @@ static void ttm_tt_clear_mapping(struct ttm_tt *ttm)
>  	pgoff_t i;
>  	struct page **page = ttm->pages;
>  
> +	if (ttm->page_flags & TTM_PAGE_FLAG_SG)
> +		return;
> +
>  	for (i = 0; i < ttm->num_pages; ++i) {
>  		(*page)->mapping = NULL;
>  		(*page++)->index = 0;
> --
> 1.7.10.4
>