From: Markus Armbruster <armbru@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [PATCH 1/3] scripts/qapi: enum with conditional first item must be optional
Date: Fri, 07 Aug 2026 15:27:38 +0200 [thread overview]
Message-ID: <875x1moyb9.fsf@pond.sub.org> (raw)
In-Reply-To: <CABgObfbOVY5mpyhxQHOCvVDZkOHgTK=SmJ-gQ3A6_4Ywhhew_Q@mail.gmail.com> (Paolo Bonzini's message of "Fri, 7 Aug 2026 15:02:14 +0200")
Paolo Bonzini <pbonzini@redhat.com> writes:
> On Thu, Aug 6, 2026 at 9:01 AM Markus Armbruster <armbru@redhat.com> wrote:
[...]
>> If forbidding empty enums makes Rust generation simpler or easier,
>> that's a compelling reason, isn't it?
>>
>> You should mention the Rust reason(s) in the commit message then.
>
> Rust can live with it. I'm just taking a clue from the language.
No objection.
>> I might have banned conditional first members from the start if I had
>> thought out things back then.
>
> Ok, then let's do it.
Likewise.
next prev parent reply other threads:[~2026-08-07 13:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-24 13:00 [PATCH resend 0/3] scripts/qapi: non-Rust-specific preparatory patches Paolo Bonzini
2026-07-24 13:00 ` [PATCH 1/3] scripts/qapi: enum with conditional first item must be optional Paolo Bonzini
2026-07-25 6:15 ` Markus Armbruster
2026-07-25 12:20 ` Paolo Bonzini
2026-07-27 9:32 ` Markus Armbruster
2026-08-03 5:14 ` Paolo Bonzini
2026-08-06 7:00 ` Markus Armbruster
2026-08-07 13:02 ` Paolo Bonzini
2026-08-07 13:27 ` Markus Armbruster [this message]
2026-07-24 13:00 ` [PATCH 2/3] scripts/qapi: reject empty enums Paolo Bonzini
2026-07-27 8:47 ` Markus Armbruster
2026-07-24 13:00 ` [PATCH 3/3] scripts/qapi: pull c_name and lstrip from camel_to_upper to caller Paolo Bonzini
2026-08-03 10:19 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875x1moyb9.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.