From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 291D6379C50; Mon, 6 Jul 2026 13:18:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783343906; cv=none; b=Ti+5TqD5k5Rm0RKbhdnnrJrvF+sZ2PWxrfmn3lZmlyaej5MSH90iJ67fpvhrsYTQbwJhIMw4oG77Jg/iIdDAWRgFYrBbyo3b7/Yw/BJOZvoqR0JqpSk6gvB5zFSyFvjwQkMpJgSdYOtOmtXUi1cNf4a+hSz8CDxpNeC7vQnpnAI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783343906; c=relaxed/simple; bh=U0UUTPXYOIMUbfKiPj5WyHNGQxtCYRhMQN2tHOjGjGI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=PJSV32a800WzIpiSEfBfiOStdClmB/zYRl0/iq+zLAaZiWGDjjuu6gEy1blQcD9XSaCr3F8XQl0fKh6M+hSFRqGPFWQo24h4ocB8rh/N3hNX+TultoboiSKK9wnJUJrY9W2N00/957vxsxfV9AGC1WP5uUhCeXu9GGOi6OQkqws= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=cSoSugdu; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="cSoSugdu" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 852B0C8EC7B; Mon, 6 Jul 2026 13:18:35 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 66252601A2; Mon, 6 Jul 2026 13:18:22 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id C780C11BB817F; Mon, 6 Jul 2026 15:18:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1783343901; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=U0UUTPXYOIMUbfKiPj5WyHNGQxtCYRhMQN2tHOjGjGI=; b=cSoSugduSkj26OSLyr0eg4z0X07uDcmEPgzzCoZ4G5miflrsmGdrvIOatE6BgNtt0iiJG6 WzZpJnWsVmaHT/XKbJvTYwstnmDNVbAQIbbye7xFfNThHAc/4DCIe7/4VWXaHPv7mYD8LI 8tvomJnUel812gpqO7ixkDOfIEjlPHZvFfr7+1u0OBmkL0DKLzqiAGDYNpUUuCR37CUEdl 2u6zoFIvF6O6NOfT0AJvy41LYQ9MlvJdeK2JuT8wX+DWqzJDyM+w19IfLUxDqCBEpIDMTs vf7X/F247KGIweN/KPkCdGoAjLG/zvWHvtjsW72LkuiRzQrCA+4jXNzVPJhoOA== From: Miquel Raynal To: Stephan Gerhold Cc: Richard Weinberger , Vignesh Raghavendra , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-mtd@lists.infradead.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam Subject: Re: [PATCH 0/4] mtd: rawnand: qcom: Add MDM9607 In-Reply-To: (Stephan Gerhold's message of "Mon, 6 Jul 2026 14:55:26 +0200") References: <20260608-qcom-nandc-mdm9607-v1-0-4639a0492274@linaro.org> <4kdjxrn3bxg7rhkdovidxv2b2f6evnknng7gjtbz7pahyqaakh@qkgxaz6xlav2> User-Agent: mu4e 1.12.7; emacs 30.2 Date: Mon, 06 Jul 2026 15:18:18 +0200 Message-ID: <875x2smf39.fsf@bootlin.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 Hi Stephan, On 06/07/2026 at 14:55:26 +02, Stephan Gerhold = wrote: > Hi Miqu=C3=A8l, > > On Mon, Jun 29, 2026 at 05:46:57PM +0200, Manivannan Sadhasivam wrote: >> On Mon, Jun 08, 2026 at 03:20:21PM +0200, Stephan Gerhold wrote: >> > MDM9607 has QPIC v1.5 that supports the OP_PAGE_READ_ONFI_READ command= , but >> > is missing the rest of the hardware changes in QPIC v2. There is also = only >> > a single clock that can be controlled using the RPM firmware. Document= and >> > add the new qcom,mdm9607-nand compatible for this setup. >> >=20 >> > Signed-off-by: Stephan Gerhold >>=20 >> You could ammend patch 1's commit message with the information I shared = in the >> reply. But nevertheless: >>=20 >> Reviewed-by: Manivannan Sadhasivam >>=20 > > Do you want me to resend the series with patch 1 commit message > adjusted? There were no other changes requested as far as I can tell. I was mostly waiting for answers on my questions from the DT binding maintainers, but I understand they must be too loaded at the moment. > I think the current commit message there is fine, especially if you add > the Link: tag during applying. The extra context will be there. > > If you want me to resend, I would just replace the second paragraph in > patch 1 with the following: > > --- > On MDM9607 and other recent SoCs, the QPIC hardware requires 3 clocks > (ahb, core, aon). However, the access to these clocks is restricted to > the RPM firmware that controls the shared power resources for the whole > SoC. The clocks cannot be controlled separately, there is only a single > RPM_SMD_QPIC_CLK clock that implicitly enables all of the 3 clocks. > The only exception to this are some IPQ* SoC that are not using RPM, > there the clocks are directly controlled by the kernel via the clock > controller (GCC). Require only one clock in the dt-bindings for MDM9607 > to avoid having to define dummy clock entries. I am sorry but this is still incorrect. You don't have to define 2 dummy clocks. You would have to define 3 times the same clock (and that's not a problem). I have been working on the concept of clock nexus which may solve this kind of issue in a rather elegant way but that's not ready yet. In my opinion the binding that you want to push (a single clock) is wrong, but since I've been explaining this for several weeks already, please at least fix the commit message and I will take it as you want. Thanks, Miqu=C3=A8l From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7F660C43458 for ; Mon, 6 Jul 2026 13:18:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=csL7rdfA6wWnK+zvq6kfN7AXy2Vy1qyc1fJGwPg1KWY=; b=JYnD8PwXA0oo1H KEqjNqd/9Umsyl0wyknxjtLEj1QVmAc5zevotTSVSSbqxaGARaEftNo7dB/yt6htQq1/Y+G1m43bG eZIOdiSNJMoSI0heo8In7HIrItFFDJoJtZ/Kwg0n3QUtVhECZcG2FyGV8wZQik39DtzD7K62v9lgy G6CmsxmVbttXb6RjV/gPXMGm8hATatwZrE2lVp/3bqhDLWyPY4ArR9m/ipmG5vlGPiY+bi5CkSKdj 9tMIPt/IsVwAOUM3rH3Vfico+gEf+eeV0qK7hdRdiyP5ksORcdo9o2aGkUP7YLTl2afeQW+7HigNF bbk34r+/8TcxVSKPDQuA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wgjDk-0000000CYMe-0zKh; Mon, 06 Jul 2026 13:18:48 +0000 Received: from smtpout-02.galae.net ([185.246.84.56]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wgjDc-0000000CYKd-1yc0 for linux-mtd@lists.infradead.org; Mon, 06 Jul 2026 13:18:45 +0000 Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 9B4991A0E90; Mon, 6 Jul 2026 13:18:22 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 66252601A2; Mon, 6 Jul 2026 13:18:22 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id C780C11BB817F; Mon, 6 Jul 2026 15:18:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1783343901; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=U0UUTPXYOIMUbfKiPj5WyHNGQxtCYRhMQN2tHOjGjGI=; b=cSoSugduSkj26OSLyr0eg4z0X07uDcmEPgzzCoZ4G5miflrsmGdrvIOatE6BgNtt0iiJG6 WzZpJnWsVmaHT/XKbJvTYwstnmDNVbAQIbbye7xFfNThHAc/4DCIe7/4VWXaHPv7mYD8LI 8tvomJnUel812gpqO7ixkDOfIEjlPHZvFfr7+1u0OBmkL0DKLzqiAGDYNpUUuCR37CUEdl 2u6zoFIvF6O6NOfT0AJvy41LYQ9MlvJdeK2JuT8wX+DWqzJDyM+w19IfLUxDqCBEpIDMTs vf7X/F247KGIweN/KPkCdGoAjLG/zvWHvtjsW72LkuiRzQrCA+4jXNzVPJhoOA== From: Miquel Raynal To: Stephan Gerhold Cc: Richard Weinberger , Vignesh Raghavendra , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-mtd@lists.infradead.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam Subject: Re: [PATCH 0/4] mtd: rawnand: qcom: Add MDM9607 In-Reply-To: (Stephan Gerhold's message of "Mon, 6 Jul 2026 14:55:26 +0200") References: <20260608-qcom-nandc-mdm9607-v1-0-4639a0492274@linaro.org> <4kdjxrn3bxg7rhkdovidxv2b2f6evnknng7gjtbz7pahyqaakh@qkgxaz6xlav2> User-Agent: mu4e 1.12.7; emacs 30.2 Date: Mon, 06 Jul 2026 15:18:18 +0200 Message-ID: <875x2smf39.fsf@bootlin.com> MIME-Version: 1.0 X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260706_061841_071594_541C09B2 X-CRM114-Status: GOOD ( 26.51 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgU3RlcGhhbiwKCk9uIDA2LzA3LzIwMjYgYXQgMTQ6NTU6MjYgKzAyLCBTdGVwaGFuIEdlcmhv bGQgPHN0ZXBoYW4uZ2VyaG9sZEBsaW5hcm8ub3JnPiB3cm90ZToKCj4gSGkgTWlxdcOobCwKPgo+ IE9uIE1vbiwgSnVuIDI5LCAyMDI2IGF0IDA1OjQ2OjU3UE0gKzAyMDAsIE1hbml2YW5uYW4gU2Fk aGFzaXZhbSB3cm90ZToKPj4gT24gTW9uLCBKdW4gMDgsIDIwMjYgYXQgMDM6MjA6MjFQTSArMDIw MCwgU3RlcGhhbiBHZXJob2xkIHdyb3RlOgo+PiA+IE1ETTk2MDcgaGFzIFFQSUMgdjEuNSB0aGF0 IHN1cHBvcnRzIHRoZSBPUF9QQUdFX1JFQURfT05GSV9SRUFEIGNvbW1hbmQsIGJ1dAo+PiA+IGlz IG1pc3NpbmcgdGhlIHJlc3Qgb2YgdGhlIGhhcmR3YXJlIGNoYW5nZXMgaW4gUVBJQyB2Mi4gVGhl cmUgaXMgYWxzbyBvbmx5Cj4+ID4gYSBzaW5nbGUgY2xvY2sgdGhhdCBjYW4gYmUgY29udHJvbGxl ZCB1c2luZyB0aGUgUlBNIGZpcm13YXJlLiBEb2N1bWVudCBhbmQKPj4gPiBhZGQgdGhlIG5ldyBx Y29tLG1kbTk2MDctbmFuZCBjb21wYXRpYmxlIGZvciB0aGlzIHNldHVwLgo+PiA+IAo+PiA+IFNp Z25lZC1vZmYtYnk6IFN0ZXBoYW4gR2VyaG9sZCA8c3RlcGhhbi5nZXJob2xkQGxpbmFyby5vcmc+ Cj4+IAo+PiBZb3UgY291bGQgYW1tZW5kIHBhdGNoIDEncyBjb21taXQgbWVzc2FnZSB3aXRoIHRo ZSBpbmZvcm1hdGlvbiBJIHNoYXJlZCBpbiB0aGUKPj4gcmVwbHkuIEJ1dCBuZXZlcnRoZWxlc3M6 Cj4+IAo+PiBSZXZpZXdlZC1ieTogTWFuaXZhbm5hbiBTYWRoYXNpdmFtIDxtYW5pQGtlcm5lbC5v cmc+Cj4+IAo+Cj4gRG8geW91IHdhbnQgbWUgdG8gcmVzZW5kIHRoZSBzZXJpZXMgd2l0aCBwYXRj aCAxIGNvbW1pdCBtZXNzYWdlCj4gYWRqdXN0ZWQ/IFRoZXJlIHdlcmUgbm8gb3RoZXIgY2hhbmdl cyByZXF1ZXN0ZWQgYXMgZmFyIGFzIEkgY2FuIHRlbGwuCgpJIHdhcyBtb3N0bHkgd2FpdGluZyBm b3IgYW5zd2VycyBvbiBteSBxdWVzdGlvbnMgZnJvbSB0aGUgRFQgYmluZGluZwptYWludGFpbmVy cywgYnV0IEkgdW5kZXJzdGFuZCB0aGV5IG11c3QgYmUgdG9vIGxvYWRlZCBhdCB0aGUgbW9tZW50 LgoKPiBJIHRoaW5rIHRoZSBjdXJyZW50IGNvbW1pdCBtZXNzYWdlIHRoZXJlIGlzIGZpbmUsIGVz cGVjaWFsbHkgaWYgeW91IGFkZAo+IHRoZSBMaW5rOiB0YWcgZHVyaW5nIGFwcGx5aW5nLiBUaGUg ZXh0cmEgY29udGV4dCB3aWxsIGJlIHRoZXJlLgo+Cj4gSWYgeW91IHdhbnQgbWUgdG8gcmVzZW5k LCBJIHdvdWxkIGp1c3QgcmVwbGFjZSB0aGUgc2Vjb25kIHBhcmFncmFwaCBpbgo+IHBhdGNoIDEg d2l0aCB0aGUgZm9sbG93aW5nOgo+Cj4gLS0tCj4gT24gTURNOTYwNyBhbmQgb3RoZXIgcmVjZW50 IFNvQ3MsIHRoZSBRUElDIGhhcmR3YXJlIHJlcXVpcmVzIDMgY2xvY2tzCj4gKGFoYiwgY29yZSwg YW9uKS4gSG93ZXZlciwgdGhlIGFjY2VzcyB0byB0aGVzZSBjbG9ja3MgaXMgcmVzdHJpY3RlZCB0 bwo+IHRoZSBSUE0gZmlybXdhcmUgdGhhdCBjb250cm9scyB0aGUgc2hhcmVkIHBvd2VyIHJlc291 cmNlcyBmb3IgdGhlIHdob2xlCj4gU29DLiBUaGUgY2xvY2tzIGNhbm5vdCBiZSBjb250cm9sbGVk IHNlcGFyYXRlbHksIHRoZXJlIGlzIG9ubHkgYSBzaW5nbGUKPiBSUE1fU01EX1FQSUNfQ0xLIGNs b2NrIHRoYXQgaW1wbGljaXRseSBlbmFibGVzIGFsbCBvZiB0aGUgMyBjbG9ja3MuCj4gVGhlIG9u bHkgZXhjZXB0aW9uIHRvIHRoaXMgYXJlIHNvbWUgSVBRKiBTb0MgdGhhdCBhcmUgbm90IHVzaW5n IFJQTSwKPiB0aGVyZSB0aGUgY2xvY2tzIGFyZSBkaXJlY3RseSBjb250cm9sbGVkIGJ5IHRoZSBr ZXJuZWwgdmlhIHRoZSBjbG9jawo+IGNvbnRyb2xsZXIgKEdDQykuIFJlcXVpcmUgb25seSBvbmUg Y2xvY2sgaW4gdGhlIGR0LWJpbmRpbmdzIGZvciBNRE05NjA3Cj4gdG8gYXZvaWQgaGF2aW5nIHRv IGRlZmluZSBkdW1teSBjbG9jayBlbnRyaWVzLgoKSSBhbSBzb3JyeSBidXQgdGhpcyBpcyBzdGls bCBpbmNvcnJlY3QuIFlvdSBkb24ndCBoYXZlIHRvIGRlZmluZSAyIGR1bW15CmNsb2Nrcy4gWW91 IHdvdWxkIGhhdmUgdG8gZGVmaW5lIDMgdGltZXMgdGhlIHNhbWUgY2xvY2sgKGFuZCB0aGF0J3Mg bm90CmEgcHJvYmxlbSkuIEkgaGF2ZSBiZWVuIHdvcmtpbmcgb24gdGhlIGNvbmNlcHQgb2YgY2xv Y2sgbmV4dXMgd2hpY2gKbWF5IHNvbHZlIHRoaXMga2luZCBvZiBpc3N1ZSBpbiBhIHJhdGhlciBl bGVnYW50IHdheSBidXQgdGhhdCdzIG5vdApyZWFkeSB5ZXQuCgpJbiBteSBvcGluaW9uIHRoZSBi aW5kaW5nIHRoYXQgeW91IHdhbnQgdG8gcHVzaCAoYSBzaW5nbGUgY2xvY2spIGlzCndyb25nLCBi dXQgc2luY2UgSSd2ZSBiZWVuIGV4cGxhaW5pbmcgdGhpcyBmb3Igc2V2ZXJhbCB3ZWVrcyBhbHJl YWR5LApwbGVhc2UgYXQgbGVhc3QgZml4IHRoZSBjb21taXQgbWVzc2FnZSBhbmQgSSB3aWxsIHRh a2UgaXQgYXMgeW91IHdhbnQuCgpUaGFua3MsCk1pcXXDqGwKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eCBNVEQgZGlzY3Vzc2lvbiBt YWlsaW5nIGxpc3QKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9s aW51eC1tdGQvCg==