From: Markus Armbruster <armbru@redhat.com>
To: David Hamilton <dahamilt0@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH v2 1/2] hw/misc/ivshmem-pci: Handle error from kvm_irqchip_add_irqfd_notifier_gsi()
Date: Wed, 25 Feb 2026 14:27:44 +0100 [thread overview]
Message-ID: <875x7lkl67.fsf@pond.sub.org> (raw)
In-Reply-To: <20260225121323.5395-2-dahamilt0@gmail.com> (David Hamilton's message of "Wed, 25 Feb 2026 07:13:22 -0500")
David Hamilton <dahamilt0@gmail.com> writes:
> The return value of kvm_irqchip_add_irqfd_notifier_gsi() was being
> ignored. Propagate the error to the caller via errp.
>
> Also change setup_interrupt() to return bool to follow QEMU error
> handling conventions, making error checks at call sites simpler.
>
> Resolves the TODO comment at the call site.
>
> Signed-off-by: David Hamilton <dahamilt0@gmail.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
next prev parent reply other threads:[~2026-02-25 13:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 12:13 [PATCH v2 0/2] hw/misc/ivshmem-pci: Improve error handling David Hamilton
2026-02-25 12:13 ` [PATCH v2 1/2] hw/misc/ivshmem-pci: Handle error from kvm_irqchip_add_irqfd_notifier_gsi() David Hamilton
2026-02-25 13:27 ` Markus Armbruster [this message]
2026-02-25 12:13 ` [PATCH v2 2/2] hw/misc/ivshmem-pci: Check error after setup_interrupt() in process_msg_connect() David Hamilton
2026-02-25 13:26 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875x7lkl67.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=dahamilt0@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.